Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1169 table sort #1025

Merged
merged 3 commits into from
Feb 7, 2023
Merged

1169 table sort #1025

merged 3 commits into from
Feb 7, 2023

Conversation

chrisolsen
Copy link
Collaborator

No description provided.

@Radha-Alberta
Copy link
Contributor

Radha-Alberta commented Jan 30, 2023 •
edited
Loading

In Firefox, the sortable and non-sortable column headers are not aligned.
imageimage
image

@chrisolsen
Copy link
Collaborator Author

As I previously mentioned Firefox does not yet provide the ability to use :has() and results in this unwanted gap, but this has been discussed with Tom and we are in agreement that this is ok for now.

As for the chrome showing the same issue, this is something that does not exist when testing with an actual Android device.

ArakTaiRoth
ArakTaiRoth previously approved these changes Feb 6, 2023
View reviewed changes
amar-ABgov
amar-ABgov reviewed Feb 6, 2023
View reviewed changes
Copy link
Contributor

@amar-ABgov amar-ABgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great 👍

libs/web-components/src/components/table/TableSortHeader.svelte Outdated Show resolved Hide resolved
@amar-ABgov amar-ABgov mentioned this pull request Feb 7, 2023
Merged
@ArakTaiRoth ArakTaiRoth merged commit f673e0c into GovAlta:alpha Feb 7, 2023
@tzuge
Copy link
Collaborator

tzuge commented Feb 7, 2023

🎉 This PR is included in version 4.0.0-alpha.110 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Feb 7, 2023
@tzuge
Copy link
Collaborator

tzuge commented Feb 7, 2023

🎉 This PR is included in version 1.0.0-alpha.150 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 22, 2023

🎉 This PR is included in version 2.0.0-alpha.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 27, 2023

🎉 This PR is included in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Feb 27, 2023
@tzuge
Copy link
Collaborator

tzuge commented Feb 27, 2023

🎉 This PR is included in version 4.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 27, 2023

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 9, 2023

🎉 This PR is included in version 1.0.0-alpha.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 19, 2023

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amar-ABgov amar-ABgov amar-ABgov approved these changes

@ArakTaiRoth ArakTaiRoth ArakTaiRoth approved these changes

@Radha-Alberta Radha-Alberta Awaiting requested review from Radha-Alberta

@vanessatran-ddi vanessatran-ddi Awaiting requested review from vanessatran-ddi vanessatran-ddi is a code owner

Assignees
No one assigned
Labels
released on @alpha Released into alpha. released Released into production.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrisolsen @Radha-Alberta @tzuge @ArakTaiRoth @amar-ABgov