[v3] (part 2) Move the v1 runner components to pkg/skaffold/runner/v1.

[yuwenma]

Fixes: #nnn
Related: #5727
Merge after: #5780

Description
Changes include:

• imports changes
• public/private functions and attributes
• Simplified the runner.Tester

[codecov]

Codecov Report

Merging #5781 (ebcbdd9) into master (ce34201) will decrease coverage by 0.02%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##           master    #5781      +/-   ##
==========================================
- Coverage   70.95%   70.93%   -0.03%     
==========================================
  Files         439      438       -1     
  Lines       16408    16410       +2     
==========================================
- Hits        11642    11640       -2     
- Misses       3913     3916       +3     
- Partials      853      854       +1     

Impacted Files	Coverage Δ
pkg/skaffold/runner/builder.go	72.72% <ø> (ø)
pkg/skaffold/runner/v1/apply.go	0.00% <ø> (ø)
pkg/skaffold/runner/v1/cleanup.go	0.00% <ø> (ø)
pkg/skaffold/runner/v1/debugging.go	66.66% <ø> (ø)
pkg/skaffold/runner/v1/generate_pipeline.go	0.00% <ø> (ø)
pkg/skaffold/runner/v1/load_images.go	94.73% <ø> (ø)
pkg/skaffold/runner/v1/logger.go	40.00% <ø> (ø)
pkg/skaffold/runner/v1/portforwarder.go	22.22% <ø> (ø)
pkg/skaffold/runner/v1/render.go	12.50% <0.00%> (ø)
pkg/skaffold/runner/v1/runner.go	0.00% <0.00%> (ø)
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce34201...ebcbdd9. Read the comment docs.

[yuwenma]

Rebased after #5780 is merged.

[MarlonGamez]

Few questions:

• Should pkg/skaffold/runner/build_deploy.go be moved to pkg/skaffold/runner/v1/build_deploy.go?
• Should pkg/skaffold/runner/v1/build_deploy_test.go be deleted?
• Should pkg/skaffold/runner/prune.go be moved as well?

[yuwenma]

Few questions:

• Should pkg/skaffold/runner/build_deploy.go be moved to pkg/skaffold/runner/v1/build_deploy.go?

Both v1 and v2 will share the build_deploy logic, so it does not need to be moved (It calls a Deploy (in Deploy.go) function which will be different between v1 and v2).

• Should pkg/skaffold/runner/v1/build_deploy_test.go be deleted?

Conflict resolved. pkg/skaffold/runner/v1/build_deploy_test.go is moved to runner/v1 to make sure the v1 build_deploy works. another build_deploy_test.go will be added to v2 for the v2 build_deploy functionality.

• Should pkg/skaffold/runner/prune.go be moved as well?

prune.go is still needed.

[tejal29]

Dicussed offline

1. We want to go to a structure

runner/
  - base/
  - v1/
  - v2/

To do that, @tejal29 and @yuwenma will explore the using

1. util.VersionedConfig
2. Add interfaces for Artifact and Pipeline and get rid of latest_v1.Artifact and latest_v1.Pipeline