Explore removing latestv1.Pipeline
and latestv1.Artifact
from runner & runcontexts everywhere.
#5797
Labels
kind/todo
implementation task/epic for the skaffold team
planning/Q3-21
priority/p1
High impact feature/bug.
Milestone
Follow up from #5781 PRs
Support Skaffold cmd parser to have multiple pipeline runners.
We are adding a new render phase in a v2 runner.
This runner should be created when a V3 config is detected. However this is not possible right now.
The runner interface has
latestV1
config embedded in it.Similarly see RunContext has
latestv1.Pipeline
embedded in the struct.The current V2 runner has the following methods
where
[]graph.Artifact
haslatestV1.Artifact
field.However, the V2 runner is expected to see a
latestV2.Artifact
andlatestV2.SkaffoldConfig
. If we make that change, the v2 runner will not adhere byrunner.Runner
interface.This will mean, we will have to duplicate all code in cmd package e.g.
cmd.createNewRunner
to return a v2 runner.It would be great
cmd
package as ispkg/runner.Build
functions as build is going to be the same.Device a plan to remove the version embedded in Runner interface, RunContext struct.
The text was updated successfully, but these errors were encountered: