-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skaffold diagnose to not initialize runconfig for yaml only flag #5762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
force-pushed
the
fix_diagnose
branch
2 times, most recently
from
April 30, 2021 00:13
7a1957e
to
f6b5200
Compare
Codecov Report
@@ Coverage Diff @@
## master #5762 +/- ##
==========================================
- Coverage 70.89% 70.70% -0.20%
==========================================
Files 421 427 +6
Lines 16091 16181 +90
==========================================
+ Hits 11408 11441 +33
- Misses 3849 3899 +50
- Partials 834 841 +7
Continue to review full report at Codecov.
|
gsquared94
reviewed
Apr 30, 2021
gsquared94
approved these changes
Apr 30, 2021
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5701
In this PR the code is refactored to make sure we don't create a skaffold RunContext object when skaffold diagnose is run with
--yaml-only
flag.