better refactor

GoogleContainerTools · Apr 30, 2021 · 7a1957e · 7a1957e
1 parent 67e2439
commit 7a1957e
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/cmd/skaffold/app/cmd/diagnose.go b/cmd/skaffold/app/cmd/diagnose.go
@@ -21,6 +21,7 @@ import (
 	"fmt"
 	"io"
 
+	"github.com/GoogleContainerTools/skaffold/pkg/skaffold/color"
 	"github.com/GoogleContainerTools/skaffold/pkg/skaffold/diagnose"
 	"github.com/GoogleContainerTools/skaffold/pkg/skaffold/parser"
 	"github.com/GoogleContainerTools/skaffold/pkg/skaffold/runner/runcontext"
@@ -56,7 +57,7 @@ func doDiagnose(ctx context.Context, out io.Writer) error {
 		return err
 	}
 	if !yamlOnly {
-		if err := printDockerArtifact(ctx, out, configs); err != nil {
+		if err := printArtifactsDiagnostics(ctx, out, configs); err != nil {
 			return err
 		}
 	}
@@ -73,7 +74,7 @@ func doDiagnose(ctx context.Context, out io.Writer) error {
 	return nil
 }
 
-func printDockerArtifact(ctx context.Context, out io.Writer, configs []*latest_v1.SkaffoldConfig) error {
+func printArtifactsDiagnostics(ctx context.Context, out io.Writer, configs []*latest_v1.SkaffoldConfig) error {
 	var pipelines []latest_v1.Pipeline
 	for _, cfg := range configs {
 		pipelines = append(pipelines, cfg.Pipeline)
@@ -93,4 +94,5 @@ func printDockerArtifact(ctx context.Context, out io.Writer, configs []*latest_v
 
 		color.Blue.Fprintln(out, "\nConfiguration")
 	}
+	return nil
 }