Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skaffold filter to handle multiple yaml documents #4829

Merged
merged 3 commits into from
Sep 29, 2020

Conversation

briandealwis
Copy link
Member

Fixes: #4826,
Related: #4827, #4732

Description
As discovered by @doriandekoning in #4826, the new Helm debug support does correctly handle the situation where a Helm chart may have multiple resources.

This PR does the following:

  • it introduces a manifest.Load() function to create a ManifestList from a YAML input leveraging the k8s.io/apimachinery's YAMLReader.
  • filter now uses manifest.Load() to parse the manifests proferred on stdin
  • adds a test for debug to verify that it applies to multiple manifests

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #4829 into master will increase coverage by 0.01%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4829      +/-   ##
==========================================
+ Coverage   71.72%   71.73%   +0.01%     
==========================================
  Files         353      353              
  Lines       12099    12108       +9     
==========================================
+ Hits         8678     8686       +8     
- Misses       2775     2776       +1     
  Partials      646      646              
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/filter.go 26.82% <0.00%> (+0.63%) ⬆️
pkg/skaffold/kubernetes/manifest/manifests.go 91.48% <80.00%> (-3.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4bd638...ec6e927. Read the comment docs.

@briandealwis briandealwis added the kokoro:force-run forces a kokoro re-run on a PR label Sep 29, 2020
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Sep 29, 2020
@briandealwis briandealwis merged commit 2d7c4fd into GoogleContainerTools:master Sep 29, 2020
@briandealwis briandealwis deleted the i4827 branch September 29, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold debug when using helm does not work when helm chart renders more than one manifest
4 participants