Fix skaffold filter
to handle multiple yaml documents
#4829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4826,
Related: #4827, #4732
Description
As discovered by @doriandekoning in #4826, the new Helm debug support does correctly handle the situation where a Helm chart may have multiple resources.
This PR does the following:
manifest.Load()
function to create aManifestList
from a YAML input leveraging thek8s.io/apimachinery
'sYAMLReader
.filter
now usesmanifest.Load()
to parse the manifests proferred on stdindebug
to verify that it applies to multiple manifests