-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skaffold debug does not work for helm deployments with multiple … #4827
fix: skaffold debug does not work for helm deployments with multiple … #4827
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #4827 +/- ##
==========================================
- Coverage 71.72% 71.71% -0.01%
==========================================
Files 353 353
Lines 12099 12100 +1
==========================================
Hits 8678 8678
- Misses 2775 2776 +1
Partials 646 646
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this — I'll fix this up and add some further tests.
Fixes: #4826
Related:#4732
Merge before/after: None
Description
This mr splits the rendered helm resources in the
skaffold filter
command on---
which separates resources. Currently only the first resource is modified, this causes the debug command not to work. In this mr the input onfilter
(the rendered helm resources) is split on---
and to each resource the debugging transformations are applied.I'd like to add some tests but there are currently no meaning full tests for the filter command (as far as I can see) which I can extend.