Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skaffold debug does not work for helm deployments with multiple … #4827

Conversation

doriandekoning
Copy link

@doriandekoning doriandekoning commented Sep 28, 2020

Fixes: #4826
Related:#4732
Merge before/after: None
Description
This mr splits the rendered helm resources in the skaffold filter command on --- which separates resources. Currently only the first resource is modified, this causes the debug command not to work. In this mr the input on filter (the rendered helm resources) is split on --- and to each resource the debugging transformations are applied.

I'd like to add some tests but there are currently no meaning full tests for the filter command (as far as I can see) which I can extend.

@doriandekoning doriandekoning requested a review from a team as a code owner September 28, 2020 13:34
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@doriandekoning
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #4827 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4827      +/-   ##
==========================================
- Coverage   71.72%   71.71%   -0.01%     
==========================================
  Files         353      353              
  Lines       12099    12100       +1     
==========================================
  Hits         8678     8678              
- Misses       2775     2776       +1     
  Partials      646      646              
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/filter.go 25.58% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4bd638...2cc698c. Read the comment docs.

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this — I'll fix this up and add some further tests.

cmd/skaffold/app/cmd/filter.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants