Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold deploy -t flag #4778

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Conversation

anshlykov
Copy link
Contributor

@anshlykov anshlykov commented Sep 13, 2020

Fixes: #4455

Description
This PR adds the --tag flag to the deploy command. If the '--tag' flag is present, then the tags for all artifacts are overridden.

Perhaps the deploy command should only use the new tag for artifacts for which the image tag is not explicitly specified. Let me know if I need to change anything.

@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

Merging #4778 into master will increase coverage by 0.00%.
The diff coverage is 77.77%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4778   +/-   ##
=======================================
  Coverage   73.84%   73.85%           
=======================================
  Files         347      347           
  Lines       13753    13825   +72     
=======================================
+ Hits        10156    10210   +54     
- Misses       2965     2976   +11     
- Partials      632      639    +7     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 86.36% <ø> (ø)
cmd/skaffold/app/cmd/deploy.go 69.64% <76.47%> (+2.97%) ⬆️
pkg/skaffold/build/tag/util.go 90.90% <80.00%> (-9.10%) ⬇️
pkg/skaffold/build/cache/lookup.go 88.73% <0.00%> (-11.27%) ⬇️
pkg/skaffold/build/cache/details.go 13.79% <0.00%> (-1.03%) ⬇️
pkg/skaffold/docker/parse.go 89.05% <0.00%> (-0.90%) ⬇️
pkg/skaffold/deploy/helm.go 78.89% <0.00%> (+0.11%) ⬆️
pkg/skaffold/runner/new.go 68.18% <0.00%> (+0.63%) ⬆️
pkg/skaffold/build/cache/cache.go 57.77% <0.00%> (+0.95%) ⬆️
pkg/skaffold/build/cache/retrieve.go 70.65% <0.00%> (+1.33%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2582151...23d1690. Read the comment docs.

@anshlykov anshlykov marked this pull request as ready for review September 13, 2020 21:37
@anshlykov anshlykov requested a review from a team as a code owner September 13, 2020 21:37
@anshlykov anshlykov requested a review from tejal29 September 13, 2020 21:37
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change :) we're having some issues with CI right now so I'm gonna approve this and I'll merge it once we get stuff working again

@MarlonGamez MarlonGamez merged commit 44c3768 into GoogleContainerTools:master Sep 18, 2020
@anshlykov anshlykov deleted the gh-4455 branch September 29, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold deploy to support -t for tags
3 participants