Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold deploy to support -t for tags #4455

Closed
matti opened this issue Jul 9, 2020 · 3 comments · Fixed by #4778
Closed

skaffold deploy to support -t for tags #4455

matti opened this issue Jul 9, 2020 · 3 comments · Fixed by #4778
Labels

Comments

@matti
Copy link
Contributor

matti commented Jul 9, 2020

skaffold.yaml:

apiVersion: skaffold/v2alpha2
kind: Config
build:
  artifacts:
    - image: first
      context: components/first
    - image: second
      context: components/second
deploy:
  kustomize:
    path: kustomize

If I have already built the images I need to provide --image for every artifact:

skaffold deploy \
  -d my.registry.example.com \
  --images "first:mytag" \
  --images "second:mytag"

So if skaffold deploy supported -t like other commands, then this would become just:

skaffold deploy \
  -d my.registry.example.com \
  -t mytag

and the skaffold deploy ... command wouldn't need to know the artifacts.

@matti
Copy link
Contributor Author

matti commented Jul 9, 2020

Somewhat related to #922

@gsquared94
Copy link
Contributor

This seems like a reasonable ask. However there seem to already be a few different ways of passing info from build to deploy. We'll probably need to be a bit more consistent.

@tejal29
Copy link
Contributor

tejal29 commented Jul 13, 2020

We decided to add this feature. Removing the discuss label

@gsquared94 gsquared94 added priority/p2 May take a couple of releases area/deploy and removed triage/discuss Items for discussion labels Jul 13, 2020
@nkubala nkubala added this to the Icebox [P2+] milestone Sep 1, 2020
anshlykov added a commit to anshlykov/skaffold that referenced this issue Sep 13, 2020
MarlonGamez pushed a commit that referenced this issue Sep 18, 2020
* skaffold deploy -t flag

See #4455

* refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants