Add option to skaffold run similar to "skaffold build -b" #4734

anshlykov · 2020-08-28T15:13:06Z

Description
Added the artifact filter for the run command, similar to the build command.

googlebot · 2020-08-28T15:13:10Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

codecov · 2020-08-28T15:22:19Z

Codecov Report

Merging #4734 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4734      +/-   ##
==========================================
+ Coverage   71.82%   71.91%   +0.08%     
==========================================
  Files         347      347              
  Lines       11869    11892      +23     
==========================================
+ Hits         8525     8552      +27     
+ Misses       2725     2718       -7     
- Partials      619      622       +3

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/build.go	`89.18% <ø> (+4.97%)`	⬆️
cmd/skaffold/app/cmd/flags.go	`82.85% <ø> (ø)`
cmd/skaffold/app/cmd/run.go	`87.50% <100.00%> (+37.50%)`	⬆️
pkg/skaffold/build/tag/util.go	`89.47% <0.00%> (-10.53%)`	⬇️
cmd/skaffold/app/cmd/deploy.go	`68.75% <0.00%> (+2.08%)`	⬆️
cmd/skaffold/app/tips/tips.go	`100.00% <0.00%> (+22.22%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4eb4a...658148a. Read the comment docs.

anshlykov · 2020-08-28T15:23:32Z

@googlebot I signed it!

googlebot · 2020-08-28T15:23:36Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

gsquared94 · 2020-09-10T07:48:59Z

cmd/skaffold/app/cmd/run.go

@@ -36,13 +37,16 @@ func NewCmdRun() *cobra.Command {
 		WithExample("Build, test, deploy and tail the logs", "run --tail").
 		WithExample("Run with a given profile", "run -p <profile>").
 		WithCommonFlags().
+		WithFlags(func(f *pflag.FlagSet) {
+			f.StringSliceVarP(&opts.TargetImages, "build-image", "b", nil, "Choose which artifacts to build. Artifacts with image names that contain the expression will be built only. Default is to build sources for all artifacts")


Suggested change

f.StringSliceVarP(&opts.TargetImages, "build-image", "b", nil, "Choose which artifacts to build. Artifacts with image names that contain the expression will be built only. Default is to build sources for all artifacts")

f.StringSliceVarP(&opts.TargetImages, "build-image", "b", nil, "Only build artifacts with image names that contain the given substring. Default is to build sources for all artifacts")

nit: I know that you took the same text as the existing build-image flag on build. But the grammar seems off.

If the flag is the same elsewhere then we should instead add it to the flagRegistry.

gsquared94

LGTM

briandealwis · 2020-09-10T20:07:50Z

cmd/skaffold/app/cmd/run_test.go

+							{
+								ImageName: "first",
+							},
+							{
+								ImageName: "second-test",
+							},
+							{
+								ImageName: "test",
+							},
+							{
+								ImageName: "aaabbbccc",
+							},


These take up a lot of space!

Suggested change

{

ImageName: "first",

},

{

ImageName: "second-test",

},

{

ImageName: "test",

},

{

ImageName: "aaabbbccc",

},

{ImageName: "first"},

{ImageName: "second-test"},

{ImageName: "test"},

{ImageName: "aaabbbccc"},

gsquared94 · 2020-09-18T04:39:07Z

@anshlykov thanks for making all the suggested changes. Can you sync with the master branch; then we can merge this and call it done 👍

gsquared94 · 2020-09-21T06:28:48Z

Travis bug is showing duplicate checks and stuck on one of them. This PR's actually cleared all checks. Merging.

anshlykov · 2020-09-21T10:57:20Z

@gsquared94 thanks for resolving the merge conflict

Add option to skaffold run similar to "skaffold build -b"

d5ab9da

See GoogleContainerTools#4494

pull-request-size bot added the size/M label Aug 28, 2020

googlebot added the cla: no label Aug 28, 2020

googlebot added cla: yes and removed cla: no labels Aug 28, 2020

anshlykov marked this pull request as ready for review August 28, 2020 15:36

anshlykov requested a review from a team as a code owner August 28, 2020 15:36

anshlykov requested a review from gsquared94 August 28, 2020 15:36

gsquared94 reviewed Sep 10, 2020

View reviewed changes

gsquared94 approved these changes Sep 10, 2020

View reviewed changes

gsquared94 added the kokoro:run runs the kokoro jobs on a PR label Sep 10, 2020

kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Sep 10, 2020

briandealwis reviewed Sep 10, 2020

View reviewed changes

fix comments

ebd1ee7

nkubala assigned gsquared94 Sep 17, 2020

gsquared94 added 2 commits September 18, 2020 21:44

Merge branch 'master' into GoogleContainerToolsgh-4496

aad0162

fix linters

658148a

gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Sep 18, 2020

kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Sep 18, 2020

gsquared94 merged commit eb86b7f into GoogleContainerTools:master Sep 21, 2020

anshlykov deleted the gh-4496 branch September 21, 2020 10:53

fmotrifork mentioned this pull request Oct 1, 2020

skaffold 1.15.0 fishworks/fish-food#989

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add option to skaffold run similar to "skaffold build -b" #4734

Add option to skaffold run similar to "skaffold build -b" #4734

anshlykov commented Aug 28, 2020

googlebot commented Aug 28, 2020

codecov bot commented Aug 28, 2020 •

edited

Loading

anshlykov commented Aug 28, 2020

googlebot commented Aug 28, 2020

gsquared94 Sep 10, 2020

briandealwis Sep 10, 2020

gsquared94 left a comment

briandealwis Sep 10, 2020

gsquared94 commented Sep 18, 2020

gsquared94 commented Sep 21, 2020

anshlykov commented Sep 21, 2020

	f.StringSliceVarP(&opts.TargetImages, "build-image", "b", nil, "Choose which artifacts to build. Artifacts with image names that contain the expression will be built only. Default is to build sources for all artifacts")
	f.StringSliceVarP(&opts.TargetImages, "build-image", "b", nil, "Only build artifacts with image names that contain the given substring. Default is to build sources for all artifacts")

Add option to skaffold run similar to "skaffold build -b" #4734

Add option to skaffold run similar to "skaffold build -b" #4734

Conversation

anshlykov commented Aug 28, 2020

googlebot commented Aug 28, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

codecov bot commented Aug 28, 2020 • edited Loading

Codecov Report

anshlykov commented Aug 28, 2020

googlebot commented Aug 28, 2020

gsquared94 Sep 10, 2020

Choose a reason for hiding this comment

briandealwis Sep 10, 2020

Choose a reason for hiding this comment

gsquared94 left a comment

Choose a reason for hiding this comment

briandealwis Sep 10, 2020

Choose a reason for hiding this comment

gsquared94 commented Sep 18, 2020

gsquared94 commented Sep 21, 2020

anshlykov commented Sep 21, 2020

codecov bot commented Aug 28, 2020 •

edited

Loading