Refactor Tag: GenerateTag method and GenerateFQIN function #4496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Generate FQIN
Codecov Report
@@ Coverage Diff @@
## master #4496 +/- ##
==========================================
+ Coverage 72.37% 72.40% +0.03%
==========================================
Files 333 334 +1
Lines 12944 12968 +24
==========================================
+ Hits 9368 9390 +22
- Misses 2980 2982 +2
Partials 596 596
Continue to review full report at Codecov.
|
yuwenma
reviewed
Jul 20, 2020
yuwenma
approved these changes
Jul 21, 2020
nkubala
reviewed
Jul 22, 2020
MarlonGamez
approved these changes
Jul 22, 2020
gsquared94
added a commit
to anshlykov/skaffold
that referenced
this pull request
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a non-functional change. Previously, taggers only had the option to generate the entire image name. This change provides a method for taggers to only generate the tag portion. This refactoring is in preparation for another change. This PR also addresses the comments left on #4480.
Follow-up Work (remove if N/A)
This refactoring is in preparation for the feature associated with issue #4371.
I plan to deprecate the usage of
{{.IMAGE_NAME}}in theenvTemplatetagger to improve its consistency with the other taggers.