Support configuring default namespace for kubectl/kustomize deployers

[AndiDog]

Fixes: #3172
Related: n/a
Merge before/after: n/a

Description

Support configuring default namespace for kubectl/kustomize deployers. The Helm deployer luckily already had this (release namespace). In addition, all three deployers now allow templating for those fields, which makes sense e.g. for per-user environments with a namespace of dev-{{.USER}}.

With this change, users don't explicitly have to specify -n targetnamespace all the time, and instead declaratively configure – maybe even per profile – which namespace the application should be deployed to. Command line argument / environment variable still take precedence, as expected in most Unix-like tools.

[codecov]

Codecov Report

Merging #4374 into master will decrease coverage by 0.01%.
The diff coverage is 65.00%.

@@            Coverage Diff             @@
##           master    #4374      +/-   ##
==========================================
- Coverage   73.85%   73.83%   -0.02%     
==========================================
  Files         347      347              
  Lines       13796    13867      +71     
==========================================
+ Hits        10189    10239      +50     
- Misses       2972     2984      +12     
- Partials      635      644       +9     

Impacted Files	Coverage Δ
pkg/skaffold/schema/latest/config.go	100.00% <ø> (ø)
pkg/skaffold/deploy/helm.go	76.98% <31.25%> (-1.91%)	⬇️
pkg/skaffold/runner/new.go	66.25% <62.50%> (-1.93%)	⬇️
pkg/skaffold/deploy/kubectl.go	68.26% <77.77%> (+0.13%)	⬆️
pkg/skaffold/deploy/kustomize.go	79.31% <77.77%> (-0.34%)	⬇️
pkg/skaffold/build/cluster/types.go	100.00% <100.00%> (ø)
pkg/skaffold/deploy/kubectl/cli.go	88.63% <100.00%> (ø)
pkg/skaffold/deploy/resource/deployment.go	91.54% <100.00%> (ø)
pkg/skaffold/kubectl/cli.go	100.00% <100.00%> (ø)
pkg/skaffold/sync/types.go	100.00% <100.00%> (ø)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10275c6...f7e7b94. Read the comment docs.

[gsquared94]

unfortunately the script to generate new config is currently broken. Once that gets fixed and applied you should be able rebase to fix the tests. We'll just have to wait until then, sorry.

[gsquared94]

A new config version was created. Can you try to rebase on master.

[MarlonGamez]

Hi @AndiDog , it looks like this hasn't been touched for a bit, so I think this PR will need to be rebased. If you fix the conflicts and @ me, I'll try to review this asap

[AndiDog]

@MarlonGamez Rebased, and tests + new feature are working for me locally. Didn't run integration tests, so let's see what CI says.

[MarlonGamez]

Hey again, we actually released v2beta7 last week, so I think you'll have to rebase again make the changes to v2beta8. Really sorry that this is turning out to be such a hassle :(

[AndiDog]

@MarlonGamez Rebased again and recreated the JSON file. Hope it's building now.

[MarlonGamez]

Just did a final review to double check everything, and it looks good to me :) thanks again for being patient with the rebases and what not