-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespace configuration option for kubectl/kustomize #3172
Comments
@AndiDog there is a |
Sorry, a CLI argument is not a solution as I described in the summary. Can you please reopen, considering this use case? I'm even eager to implement that – shouldn't be too hard. |
I'm open for adding this, and thank you @AndiDog for volunteering to implement it :) |
As an update: I've looked into this, but still have to find some more time to see how it can be done – right now, most code uses the run context namespace, and that would need to be overridden/changed by configuration. Any hints welcome. |
@AndiDog - Is this still being worked on? Let us know if there is anything in particular we can help with. |
I made a start on it, but didn't get it finished yet. Too busy, and was also waiting on another PR. Hopefully I can progress here soon. |
Expected behavior
Target deployment namespace should be specifiable in skaffold.yaml, e.g.
deploy:kubectl:namespace
.Actual behavior
The
helm
deployer supports deploying to a certain namespace as specified in skaffold.yaml, but for kubectl/kustomize deployers, that can only be achieved with the environment variableSKAFFOLD_NAMESPACE
or-n/--namespace
CLI option.Information
This is helpful if the namespace depends on the environment, e.g. dev/prod using a different namespace, but the values are still fixed and should therefore not require any special env var or CLI parameter to run a deployment correctly.
Probably somewhat relevant for #915 (similar use case).
The text was updated successfully, but these errors were encountered: