Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kustomize build args part 1 #2870

Merged
merged 1 commit into from
Sep 12, 2019
Merged

kustomize build args part 1 #2870

merged 1 commit into from
Sep 12, 2019

Conversation

daddz
Copy link
Contributor

@daddz daddz commented Sep 12, 2019

See: #2700

@codecov
Copy link

codecov bot commented Sep 12, 2019 •
edited
Loading

Codecov Report

Merging #2870 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/kustomize.go 73.77% <100%> (+2.34%) ⬆️

@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Sep 12, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Sep 12, 2019
@tejal29
Copy link
Contributor

tejal29 commented Sep 12, 2019

Thank you for @daddz for breaking the PR.

@tejal29 tejal29 merged commit caea6b7 into GoogleContainerTools:master Sep 12, 2019
@tejal29 tejal29 mentioned this pull request Sep 16, 2019
Closed
@dgageot dgageot mentioned this pull request Apr 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daddz @tejal29 @googlebot @kokoro-team