add option to pass arguments to kustomize, fixes #2488

[daddz]

Related issue: #2488

[daddz]

What is the preferred format here?

deploy:
  kustomize:
    build:
        - "--load_restrictor none"

or

deploy:
  kustomize:
    build:
        - "--load_restrictor"
        - "none"

I went with the first option for now but could easily change to option 2.

[nkubala]

What is the preferred format here?

both of those formats will be supported by this change. I think splitting on spaces is probably fine, though this is kind of a weird way to specify args IMO (--load_restrictor=none seems easier to reason about to me)

[daddz]

@nkubala, thanks for the feedback! I addressed your comments.
I've seen there's been a freeze for v1beta13. Shall I rebase and move these changes to v1beta14?

[tejal29]

@daddz,
Can you please do the following break this change in 2 changes ?

1. Add BuildArgs field to KustomizeDeployer struct

   • Add a function buildCommandArgs which refactors L251 to L269

       def buildCommandArgs(args []string) []args {
     
     
        } 
     

   • Add unit tests

2. Finally make a change to skaffold config KustomizeDeploy and add an example in integration/examples/kustomize or some documentation on how to use it?

[daddz]

@tejal29 Sure thing, I'll look into it tomorrow/friday.

[tejal29]

This is now merged as #2871 and #2870