add render interface to deployers which is not implemented #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
requested review from
balopat,
dgageot,
nkubala and
priyawadhwa
as code owners
Codecov Report
|
tejal29
force-pushed
the
add_render_method
branch
from
043bc73 to
ddfaa30
Compare
nkubala
approved these changes
Sep 16, 2019
priyawadhwa
approved these changes
Sep 16, 2019
pkg/skaffold/runner/runner_test.go
Outdated
| @@ -170,6 +170,10 @@ func (t *TestBench) Deploy(_ context.Context, _ io.Writer, artifacts []build.Art | |||
| return deploy.NewDeploySuccessResult(t.namespaces) | |||
| } | |||
|
|
|||
| func (t *TestBench) Render(_ context.Context, _ io.Writer, artifacts []build.Artifact, _ string) error { | |||
| return fmt.Errorf("not yet implemented") | |||
There was a problem hiding this comment.
nit: return errors.New() , just to match the other ones? :)
tejal29
force-pushed
the
add_render_method
branch
from
9bf8c9b to
be2ed9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #1187 and #1937
In this PR, we define an interface
Renderto Deployer and all the deployers have no implementation.Next