Skip to content

Commit

Permalink
use errors.New instead of fmt.Errorf
Browse files Browse the repository at this point in the history
  • Loading branch information
tejal29 committed Sep 16, 2019
1 parent ddfaa30 commit be2ed9e
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion pkg/skaffold/deploy/helm.go
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ func (h *HelmDeployer) joinTagsToBuildResult(builds []build.Artifact, params map
}

func (h *HelmDeployer) Render(context.Context, io.Writer, []build.Artifact, string) error {
return fmt.Errorf("not yet implemented")
return errors.New("not yet implemented")
}

func evaluateReleaseName(nameTemplate string) (string, error) {
Expand Down
3 changes: 1 addition & 2 deletions pkg/skaffold/deploy/kubectl.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ package deploy
import (
"bytes"
"context"
"fmt"
"io"
"strings"

Expand Down Expand Up @@ -254,5 +253,5 @@ func (k *KubectlDeployer) readRemoteManifest(ctx context.Context, name string) (
}

func (k *KubectlDeployer) Render(context.Context, io.Writer, []build.Artifact, string) error {
return fmt.Errorf("not yet implemented")
return errors.New("not yet implemented")
}
2 changes: 1 addition & 1 deletion pkg/skaffold/deploy/kustomize.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ func (k *KustomizeDeployer) Dependencies() ([]string, error) {
}

func (k *KustomizeDeployer) Render(context.Context, io.Writer, []build.Artifact, string) error {
return fmt.Errorf("not yet implemented")
return errors.New("not yet implemented")
}

func dependenciesForKustomization(dir string) ([]string, error) {
Expand Down
3 changes: 2 additions & 1 deletion pkg/skaffold/runner/runner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package runner

import (
"context"
"errors"
"fmt"
"io"
"io/ioutil"
Expand Down Expand Up @@ -171,7 +172,7 @@ func (t *TestBench) Deploy(_ context.Context, _ io.Writer, artifacts []build.Art
}

func (t *TestBench) Render(_ context.Context, _ io.Writer, artifacts []build.Artifact, _ string) error {
return fmt.Errorf("not yet implemented")
return errors.New("not yet implemented")
}

func (t *TestBench) Actions() []Actions {
Expand Down

0 comments on commit be2ed9e

Please sign in to comment.