-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce linux/s390x and linux/ppc64le binaries to use in container_test #269
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,8 @@ dist: trusty | |
| arch: | ||
| - amd64 | ||
| - arm64 | ||
| - s390x | ||
| - ppc64le | ||
|
|
||
| language: go | ||
| go: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| schemaVersion: '1.0.0' | ||
| commandTests: | ||
| - name: 'bad apt-get-command' | ||
| command: ['apt-get', 'dslkfjasl'] | ||
| excludedError: ['.*FAIL.*'] | ||
| expectedOutput: ['.*Usage.*'] | ||
| - name: 'apt-config' | ||
| command: ['apt-config', 'dump'] | ||
| expectedOutput: ['Acquire::Retries "3"'] | ||
| name: 'apt-config' | ||
| - name: 'path' | ||
| command: ['sh', '-c', 'echo $PATH'] | ||
| expectedOutput: ['/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'] | ||
| fileContentTests: | ||
| - name: 'Debian Sources' | ||
| excludedContents: ['.*gce_debian_mirror.*'] | ||
| expectedContents: ['.*httpredir\.debian\.org.*'] | ||
| path: '/etc/apt/sources.list' | ||
| - name: 'Wrong Retry Policy' | ||
| expectedContents: ['Acquire::Retries 4;'] | ||
| path: '/etc/apt/apt.conf.d/apt-retry' | ||
| fileExistenceTests: | ||
| - name: 'Fake Dir' | ||
| path: '/foo/bar' | ||
| shouldExist: true | ||
| - name: 'Wrong permissions' | ||
| path: '/etc/apt/sources.list' | ||
| permissions: '-rwxrwxrwx' | ||
| shouldExist: true | ||
| licenseTests: | ||
| - debian: true | ||
| files: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| schemaVersion: '2.0.0' # Make sure to test the latest schema version | ||
| metadataTest: | ||
| env: | ||
| - key: 'SOME_KEY' | ||
| value: 'SOME_VAL' | ||
| - key: 'EMPTY_VAR' | ||
| value: '' | ||
| - key: 'FOO_BAR' | ||
| value: 'FOO\:BAR=BAZ' | ||
| - key: 'REGEX_VAR' | ||
| value: '[a-z]+-2\.1\.*' | ||
| isRegex: true | ||
| labels: | ||
| - key: 'localnet.localdomain.commit_hash' | ||
| value: '0123456789abcdef0123456789abcdef01234567' | ||
| - key: 'localnet.my-domain.my-label' | ||
| value: 'my .+ label' | ||
| isRegex: true | ||
| - key: 'label-with-empty-val' | ||
| value: '' | ||
| unexposedPorts: ['80'] | ||
| unmountedVolumes: ['/root'] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| schemaVersion: '2.0.0' # Make sure to test the latest schema version | ||
| commandTests: | ||
| - name: 'apt-get' | ||
| command: 'apt-get' | ||
| args: ['help'] | ||
| excludedError: ['.*FAIL.*'] | ||
| expectedOutput: ['.*Usage.*'] | ||
| - name: 'apt-config' | ||
| command: 'apt-config' | ||
| args: ['dump'] | ||
| expectedOutput: ['APT::AutoRemove'] | ||
| - name: 'path' | ||
| command: 'sh' | ||
| args: ['-c', 'echo $PATH'] | ||
| expectedOutput: ['/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'] | ||
| fileContentTests: | ||
| - name: 'Debian Sources' | ||
| excludedContents: ['.*gce_debian_mirror.*'] | ||
| expectedContents: ['.*ports\.ubuntu\.com.*'] | ||
| path: '/etc/apt/sources.list' | ||
| - name: 'Passwd file' | ||
| expectedContents: ['root:x:0:0:root:/root:/bin/bash'] | ||
| path: '/etc/passwd' | ||
| fileExistenceTests: | ||
| - name: 'Root' | ||
| path: '/' | ||
| shouldExist: true | ||
| uid: 0 | ||
| gid: 0 | ||
| - name: 'Date' | ||
| path: '/bin/date' | ||
| isExecutableBy: 'owner' | ||
| - name: 'Hosts File' | ||
| path: '/etc/hosts' | ||
| shouldExist: true | ||
| - name: 'Machine ID' | ||
| path: '/etc/machine-id' | ||
| - name: 'Dummy File' | ||
| path: '/etc/dummy' | ||
| shouldExist: false | ||
| licenseTests: | ||
| - debian: false | ||
| files: | ||
| - "/usr/share/doc/ubuntu-keyring/copyright" | ||
| - "/usr/share/doc/dash/copyright" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| schemaVersion: '1.0.0' | ||
| commandTests: | ||
| - name: 'bad apt-get-command' | ||
| command: ['apt-get', 'dslkfjasl'] | ||
| excludedError: ['.*FAIL.*'] | ||
| expectedOutput: ['.*Usage.*'] | ||
| - name: 'apt-config' | ||
| command: ['apt-config', 'dump'] | ||
| expectedOutput: ['Acquire::Retries "3"'] | ||
| name: 'apt-config' | ||
| - name: 'path' | ||
| command: ['sh', '-c', 'echo $PATH'] | ||
| expectedOutput: ['/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'] | ||
| fileContentTests: | ||
| - name: 'Debian Sources' | ||
| excludedContents: ['.*gce_debian_mirror.*'] | ||
| expectedContents: ['.*httpredir\.debian\.org.*'] | ||
| path: '/etc/apt/sources.list' | ||
| - name: 'Wrong Retry Policy' | ||
| expectedContents: ['Acquire::Retries 4;'] | ||
| path: '/etc/apt/apt.conf.d/apt-retry' | ||
| fileExistenceTests: | ||
| - name: 'Fake Dir' | ||
| path: '/foo/bar' | ||
| shouldExist: true | ||
| - name: 'Wrong permissions' | ||
| path: '/etc/apt/sources.list' | ||
| permissions: '-rwxrwxrwx' | ||
| shouldExist: true | ||
| licenseTests: | ||
| - debian: true | ||
| files: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| schemaVersion: '2.0.0' # Make sure to test the latest schema version | ||
| metadataTest: | ||
| env: | ||
| - key: 'SOME_KEY' | ||
| value: 'SOME_VAL' | ||
| - key: 'EMPTY_VAR' | ||
| value: '' | ||
| - key: 'FOO_BAR' | ||
| value: 'FOO\:BAR=BAZ' | ||
| - key: 'REGEX_VAR' | ||
| value: '[a-z]+-2\.1\.*' | ||
| isRegex: true | ||
| labels: | ||
| - key: 'localnet.localdomain.commit_hash' | ||
| value: '0123456789abcdef0123456789abcdef01234567' | ||
| - key: 'localnet.my-domain.my-label' | ||
| value: 'my .+ label' | ||
| isRegex: true | ||
| - key: 'label-with-empty-val' | ||
| value: '' | ||
| unexposedPorts: ['80'] | ||
| unmountedVolumes: ['/root'] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| schemaVersion: '2.0.0' # Make sure to test the latest schema version | ||
| commandTests: | ||
| - name: 'apt-get' | ||
| command: 'apt-get' | ||
| args: ['help'] | ||
| excludedError: ['.*FAIL.*'] | ||
| expectedOutput: ['.*Usage.*'] | ||
| - name: 'apt-config' | ||
| command: 'apt-config' | ||
| args: ['dump'] | ||
| expectedOutput: ['APT::AutoRemove'] | ||
| - name: 'path' | ||
| command: 'sh' | ||
| args: ['-c', 'echo $PATH'] | ||
| expectedOutput: ['/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'] | ||
| fileContentTests: | ||
| - name: 'Debian Sources' | ||
| excludedContents: ['.*gce_debian_mirror.*'] | ||
| expectedContents: ['.*ports\.ubuntu\.com.*'] | ||
| path: '/etc/apt/sources.list' | ||
| - name: 'Passwd file' | ||
| expectedContents: ['root:x:0:0:root:/root:/bin/bash'] | ||
| path: '/etc/passwd' | ||
| fileExistenceTests: | ||
| - name: 'Root' | ||
| path: '/' | ||
| shouldExist: true | ||
| uid: 0 | ||
| gid: 0 | ||
| - name: 'Date' | ||
| path: '/bin/date' | ||
| isExecutableBy: 'owner' | ||
| - name: 'Hosts File' | ||
| path: '/etc/hosts' | ||
| shouldExist: true | ||
| - name: 'Machine ID' | ||
| path: '/etc/machine-id' | ||
| - name: 'Dummy File' | ||
| path: '/etc/dummy' | ||
| shouldExist: false | ||
| licenseTests: | ||
| - debian: false | ||
| files: | ||
| - "/usr/share/doc/ubuntu-keyring/copyright" | ||
| - "/usr/share/doc/dash/copyright" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any interest in adding ppc64le while you are in here? 😇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks surprisingly easy, so maybe it's a simple enough follow up. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, will check if it works for Power :)
btw, you are doing so many great things for arm64 in this direction :) Could you also take into account s390x and ppc64le then 😊 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattmoor ppc64le cross compilation works. So I added it to the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I am trying to anticipate a proliferation of architectures as I'm expanding the support for things, but I'm a bit reluctant to make changes where I don't have hardware to test and abusing automated testing is impractical (e.g. cases using bazel or kind). For
koI did addko publishtesting last Friday for all four of the distroless architectures, but in general these are "just" 4 of a much longer list 😉