-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce linux/s390x and linux/ppc64le binaries to use in container_test #269
Conversation
@@ -4,6 +4,7 @@ dist: trusty | |||
arch: | |||
- amd64 | |||
- arm64 | |||
- s390x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any interest in adding ppc64le while you are in here? 😇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks surprisingly easy, so maybe it's a simple enough follow up. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, will check if it works for Power :)
btw, you are doing so many great things for arm64 in this direction :) Could you also take into account s390x and ppc64le then 😊 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattmoor ppc64le cross compilation works. So I added it to the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also take into account s390x and ppc64le
Generally I am trying to anticipate a proliferation of architectures as I'm expanding the support for things, but I'm a bit reluctant to make changes where I don't have hardware to test and abusing automated testing is impractical (e.g. cases using bazel or kind). For ko
I did add ko publish
testing last Friday for all four of the distroless architectures, but in general these are "just" 4 of a much longer list 😉
Signed-off-by: Yulia Gaponenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nkubala this generally LGTM fwiw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The binary can be cross-compiled for s390x and ppc64le. All tests in Travis are passed.
Similar to what @mattmoor is done for arm64 -> #266