Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce linux/s390x and linux/ppc64le binaries to use in container_test #269

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

barthy1
Copy link
Contributor

@barthy1 barthy1 commented Oct 30, 2020

The binary can be cross-compiled for s390x and ppc64le. All tests in Travis are passed.
Similar to what @mattmoor is done for arm64 -> #266

@@ -4,6 +4,7 @@ dist: trusty
arch:
- amd64
- arm64
- s390x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any interest in adding ppc64le while you are in here? 😇

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks surprisingly easy, so maybe it's a simple enough follow up. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, will check if it works for Power :)

btw, you are doing so many great things for arm64 in this direction :) Could you also take into account s390x and ppc64le then 😊 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattmoor ppc64le cross compilation works. So I added it to the PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also take into account s390x and ppc64le

Generally I am trying to anticipate a proliferation of architectures as I'm expanding the support for things, but I'm a bit reluctant to make changes where I don't have hardware to test and abusing automated testing is impractical (e.g. cases using bazel or kind). For ko I did add ko publish testing last Friday for all four of the distroless architectures, but in general these are "just" 4 of a much longer list 😉

@barthy1 barthy1 changed the title Produce linux/s390x binaries to use in container_test Produce linux/s390x and linux/ppc64le binaries to use in container_test Oct 30, 2020
Copy link
Contributor

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkubala this generally LGTM fwiw

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. thanks @barthy1 for the contribution and @mattmoor for the review

@nkubala nkubala merged commit 406fa03 into GoogleContainerTools:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants