Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

Merge terraform-google-conversion and terraform-validator repositories #237

Closed
6 tasks done
melinath opened this issue Jun 23, 2021 · 4 comments
Closed
6 tasks done
Assignees
Milestone

Comments

@melinath
Copy link
Member

melinath commented Jun 23, 2021

Currently, we have separate terraform-google-conversion and terraform-validator repositories. This is for historical reasons that no longer apply. We would like to combine them so that it is easier for contributors to add support for additional resources; the split is a constant source of confusion. This will also simplify making sure that changes made in Magic Modules don't break terraform-validator; currently, it's easy to make a version of terraform-google-conversion that passes its tests but doesn't work with terraform-validator.

This work should accomplish the following:

  • Rename mmv1/provider/terraform_object_library.rb to terraform_validator.rb PR
  • Update build process to refer to validator instead of google-conversion
  • Update build process to generate the code into a subdirectory of terraform-validator and run terraform-validator tests (including integration tests) TFV PR MM PR
  • Add a note to terraform-google-conversion to state that it is deprecated. (We can't delete it, at least for now, because older terraform-validator versions depend on it.)
  • Update make commands & documentation to reflect the new build process PR
  • Update issue templates to not reference terraform google conversion PR
@morgante
Copy link
Contributor

morgante commented Jun 23, 2021

Love this idea. 👍 There was a time when we thought -conversion might be generally useful, but it seems clear that a separate repo isn't required.

@melinath melinath added this to the 1.0.0 milestone Jul 19, 2021
@melinath melinath self-assigned this Jul 30, 2021
melinath added a commit to melinath/magic-modules that referenced this issue Aug 25, 2021
This removes a trailing reference to terraform-google-conversion as an 'object library'. Related to GoogleCloudPlatform/terraform-validator#237
melinath added a commit to GoogleCloudPlatform/magic-modules that referenced this issue Aug 27, 2021
This removes a trailing reference to terraform-google-conversion as an 'object library'. Related to GoogleCloudPlatform/terraform-validator#237
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this issue Aug 27, 2021
…5140)

This removes a trailing reference to terraform-google-conversion as an 'object library'. Related to GoogleCloudPlatform/terraform-validator#237

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this issue Aug 27, 2021
)

This removes a trailing reference to terraform-google-conversion as an 'object library'. Related to GoogleCloudPlatform/terraform-validator#237

Signed-off-by: Modular Magician <[email protected]>
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this issue Oct 12, 2021
…dPlatform#5140)

This removes a trailing reference to terraform-google-conversion as an 'object library'. Related to GoogleCloudPlatform/terraform-validator#237
@melinath
Copy link
Member Author

melinath commented Nov 1, 2021

This part of the process is complete. The follow-up work re: running resource tests upstream is covered by #332

@marktru
Copy link

marktru commented Dec 23, 2021

Internal issue: b/211890077

@melinath
Copy link
Member Author

This has been resolved

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants