-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate changes into TFV instead of TGC #5349
Generate changes into TFV instead of TGC #5349
Conversation
/gcbrun |
/gcbrun |
1 similar comment
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun - forked now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hesitant about making sweeping generator changes in the middle of the 4.0.0
release process, especially given that we are working on a deadline for it. Can this wait until Nov 4? (or earlier, if we finish sooner)
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211655 |
/gcbrun because the downstream prep has been merged. |
Updated TFV generation to go into TFV directly instead of into TGC. GoogleCloudPlatform/terraform-validator#331 contains an initial import plus some additional required changes (like changes to go.mod and documentation.) Tests on this PR will not be able to fully pass until that PR is merged.
See GoogleCloudPlatform/terraform-validator#237
Release Note Template for Downstream PRs (will be copied)