Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate changes into TFV instead of TGC #5349

Merged

Conversation

melinath
Copy link
Member

@melinath melinath commented Oct 19, 2021

Updated TFV generation to go into TFV directly instead of into TGC. GoogleCloudPlatform/terraform-validator#331 contains an initial import plus some additional required changes (like changes to go.mod and documentation.) Tests on this PR will not be able to fully pass until that PR is merged.

See GoogleCloudPlatform/terraform-validator#237

Release Note Template for Downstream PRs (will be copied)


@google-cla google-cla bot added the cla: yes label Oct 19, 2021
@melinath
Copy link
Member Author

/gcbrun

@melinath
Copy link
Member Author

/gcbrun

1 similar comment
@melinath
Copy link
Member Author

/gcbrun

@melinath
Copy link
Member Author

/gcbrun

@melinath
Copy link
Member Author

/gcbrun

@melinath
Copy link
Member Author

/gcbrun - forked now

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 2 deletions(-))
TF Validator: Diff ( 299 files changed, 0 insertions(+), 0 deletions(-))

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant about making sweeping generator changes in the middle of the 4.0.0 release process, especially given that we are working on a deadline for it. Can this wait until Nov 4? (or earlier, if we finish sooner)

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211655

@melinath
Copy link
Member Author

/gcbrun because the downstream prep has been merged.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 2 files changed, 5 insertions(+), 1 deletion(-))
TF Validator: Diff ( 299 files changed, 78858 deletions(-))

@melinath melinath merged commit 2b31b18 into GoogleCloudPlatform:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants