Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add updates for big query kms changes #737

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#9208

I'm assuming the input kms_key_name will remain consistent and always be the key name, I've made kms_key_version a computed value that will store the version if kmsKeyName is returned as a version.
I'm not positive that I'm not missing something, but hopefully its a star

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquery: add `kms_key_version` as an output on `bigquery_table.encryption_configuration` and the `destination_encryption_configuration` blocks of `bigquery_job.query`, `bigquery_job.load`, and `bigquery_copy`.

Derived from GoogleCloudPlatform/magic-modules#4934

* add updates for big query kms changes

* update docs for bigquery_table

Signed-off-by: Modular Magician <[email protected]>
@google-cla google-cla bot added the cla: yes label Jul 2, 2021
@modular-magician modular-magician merged commit d85c892 into GoogleCloudPlatform:master Jul 2, 2021
@modular-magician modular-magician deleted the downstream-pr-958544ec008565e9a2232c50f816e18d391a03c0 branch November 18, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preemptively handle BigQuery KMS changes
1 participant