Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add updates for big query kms changes #4934

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jun 30, 2021

Fixes hashicorp/terraform-provider-google#9208

I'm assuming the input kms_key_name will remain consistent and always be the key name, I've made kms_key_version a computed value that will store the version if kmsKeyName is returned as a version.
I'm not positive that I'm not missing something, but hopefully its a star

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquery: add `kms_key_version` as an output on `bigquery_table.encryption_configuration` and the `destination_encryption_configuration` blocks of `bigquery_job.query`, `bigquery_job.load`, and `bigquery_copy`.

@google-cla google-cla bot added the cla: yes label Jun 30, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 136 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 5 files changed, 137 insertions(+), 35 deletions(-))
TF Conversion: Diff ( 1 file changed, 33 insertions(+))

@megan07 megan07 force-pushed the megan_bq_kms_changes branch from caa7ed6 to 86dc47f Compare June 30, 2021 20:30
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 136 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 4 files changed, 136 insertions(+), 34 deletions(-))
TF Conversion: Diff ( 1 file changed, 33 insertions(+))

@megan07 megan07 requested a review from rileykarson June 30, 2021 21:10
@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeInstance_advancedMachineFeatures|TestAccComputeInstance_updateRunning_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate|TestAccContainerNodePool_withGPU You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=194483

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccComputeInstance_updateRunning_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate|TestAccContainerNodePool_withGPU Please fix these to complete your PR

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad we get to keep drift detection and expose the new value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preemptively handle BigQuery KMS changes
3 participants