Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop converting timeouts to/from minutes #426

Conversation

modular-magician
Copy link
Collaborator

Noticed this again while working on hashicorp/terraform-provider-google#3954, and figured this is as good a time as any to actually fix it.

Release Note Template for Downstream PRs (will be copied)

* all: fixed bug where timeouts specified in units other than minutes were getting incorrectly rounded. Also fixed several instances of timeout values being used from the wrong method.

Derived from GoogleCloudPlatform/magic-modules#3421

@modular-magician modular-magician merged commit a5493db into GoogleCloudPlatform:master Apr 27, 2020
@modular-magician modular-magician deleted the downstream-pr-3eee3a1e85302bb693c4afb8e9ce9d5ffbe339d6 branch November 18, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants