Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop converting timeouts to/from minutes #3421

Merged
merged 3 commits into from
Apr 27, 2020

Conversation

danawillow
Copy link
Contributor

Noticed this again while working on hashicorp/terraform-provider-google#3954, and figured this is as good a time as any to actually fix it.

Release Note Template for Downstream PRs (will be copied)

* all: fixed bug where timeouts specified in units other than minutes were getting incorrectly rounded. Also fixed several instances of timeout values being used from the wrong method.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 115 files changed, 404 insertions(+), 403 deletions(-))
Terraform Beta: Diff ( 137 files changed, 482 insertions(+), 477 deletions(-))
TF Conversion: Diff ( 2 files changed, 6 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 117 files changed, 408 insertions(+), 406 deletions(-))
Terraform Beta: Diff ( 139 files changed, 486 insertions(+), 480 deletions(-))
TF Conversion: Diff ( 2 files changed, 6 insertions(+), 5 deletions(-))

@danawillow danawillow requested a review from chrisst April 24, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants