Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute: added network_id to google_compute_network #3214

Conversation

modular-magician
Copy link
Collaborator

Add network_id to google_compute_network.

It's an integer, not a string, and follows the expected convention for naming.

This adds a note deprecating numeric_id (to be potentially removed at some later date), which will have the same value, but as a string.

Part of terraform-provider-google#20530

See also #12351 and #12339, in particular this comment, this comment, and this discussion

Let me know if you want me to break this up into two separate release notes.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `network_id` (integer) to `google_compute_network` resource and data source
compute: deprecated `numeric_id` (string) field in `google_compute_network` resource. Use the new `network_id` (integer)  field instead 

Derived from GoogleCloudPlatform/magic-modules#12504

[upstream:219edef6198ad089672bcea662015ea5a3e3594a]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner December 16, 2024 01:18
@modular-magician modular-magician requested review from shuyama1 and removed request for a team December 16, 2024 01:18
@modular-magician modular-magician merged commit dcfcf7f into GoogleCloudPlatform:main Dec 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant