compute: added numeric_id to google_compute_network data source

[wyardley]

Add numeric_id to google_compute_network data source, matching the resource.

Switch numeric_id to to be an integer internally Scrapped -- see comment below; other discussion here

I did some tests with the compute_subnetwork resource, and it doesn't seem like the switch to an integer breaks string interpolation, though it's possible this could be considered breaking in some other, more limited ways?

Followup to #12285
Part of hashicorp/terraform-provider-google#20223

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `numeric_id` to the `google_compute_network` data source

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[wyardley]

Hi @rileykarson - does this look right now?
See also the new linked issue I created.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 16 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 16 insertions(+), 1 deletion(-))

[rileykarson]

That looks right! Running tests. We could also add network_id at-will, which could be a proper int, and deprecate numeric_id for it.

Honestly I'd probably advocate for just keeping numeric_id deprecated but around for a while as the cost to keep it is low and I'd prefer less churn, although that trades off some clarity for new users.

[modular-magician]

Tests analytics

Total tests: 1069
Passed tests: 996
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log