Parse 409 error strings to determine retriable status #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <[email protected]>
modular-magician
force-pushed
the
codegen-pr-1552
branch
from
e7788f2 to
70a9b6d
Compare
|
@morgante We've started managing these PR's the same way we do with the terraform google and google-beta PR's. It's the responsibility of the Magic Modules reviewer to make sure that the upstream logic is sound and to make sure the downstream PR's didn't pull in something unexpected. If both of those look good then we are using the approval on the upstream PR as a transitive approvals of these downstreams. |
|
@chrisst Thanks, that definitely eases the burden here. |
modular-magician
pushed a commit
to modular-magician/terraform-google-conversion
that referenced
this pull request
Oct 7, 2019
…en-pr-607
Autogenerate {{Resource}}Destroy in tests.
modular-magician
pushed a commit
to modular-magician/terraform-google-conversion
that referenced
this pull request
Oct 7, 2019
…en-pr-607
Autogenerate {{Resource}}Destroy in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @chrisst