Parse 409 error strings to determine retriable status

[chrisst]

Fixes hashicorp/terraform-provider-google#3279

---

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of e5cc236.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#544
depends: GoogleCloudPlatform/terraform-google-conversion#27
depends: hashicorp/terraform-provider-google#3285

[rileykarson]

You still seemed apprehensive about using this approach in the issue- have you changed your mind or do you think we can approach this another way? This approach LGTM though.

[rileykarson]

nit: Should this be broken out to a separate block? Needing to guard against nearly every 409 type makes me feel like we should have a block if gerr.Code == 409 && strings.Contains(gerr.Body, "operationInProgress".

[chrisst]

Haha - TBH I do dislike this approach but the alternatives appear to be:
Change the client library to stop obfuscating the error
Fork the retryTimeDuration interface to allow specifying the retriable status codes
Parse the error strings

From what I can see the error reason which is 'operationInProgress' is jammed into the errror message and that's what I'm matching on. This is created from an Exception.operationInProgress so it's unlikely the reason code will change and as long as the client library isn't updated (or doesn't change it's error parsing when it is) then I find this acceptable for now.

[rileykarson]

👍

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 7b808b5.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.