Add "path" property to rewrite config for firebase hosting version #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…10448) [upstream:19039f08e6731fc0b54a3fc892c4d4d5ab9af752] Signed-off-by: Modular Magician <[email protected]>
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
merged commit 23b4f29
into
GoogleCloudPlatform:main
4 of 6 checks passed
modular-magician
deleted the
downstream-pr-19039f08e6731fc0b54a3fc892c4d4d5ab9af752
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
pathproperty togoogle_firebase_hosting_version.config.rewrites.The respective API property is documented here: https://firebase.google.com/docs/reference/hosting/rest/v1beta1/sites.versions#rewrite
This property is useful when running a Single Page Application (SPA) that uses
pushStateon Firebase Hosting, as explained here: https://firebase.google.com/docs/hosting/full-config#rewritesRelease Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10448