-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "path" property to rewrite config for firebase hosting version #10448
Add "path" property to rewrite config for firebase hosting version #10448
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFirebaseHostingVersion_firebasehostingVersionPathExample |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me from the Firebase side. Thank you for your contribution!
This PR adds a
path
property togoogle_firebase_hosting_version.config.rewrites
.The respective API property is documented here: https://firebase.google.com/docs/reference/hosting/rest/v1beta1/sites.versions#rewrite
This property is useful when running a Single Page Application (SPA) that uses
pushState
on Firebase Hosting, as explained here: https://firebase.google.com/docs/hosting/full-config#rewritesRelease Note Template for Downstream PRs (will be copied)