Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "path" property to rewrite config for firebase hosting version #10448

Conversation

mdietrichstein
Copy link
Contributor

@mdietrichstein mdietrichstein commented Apr 15, 2024

This PR adds a path property to google_firebase_hosting_version.config.rewrites.

The respective API property is documented here: https://firebase.google.com/docs/reference/hosting/rest/v1beta1/sites.versions#rewrite

This property is useful when running a Single Page Application (SPA) that uses pushState on Firebase Hosting, as explained here: https://firebase.google.com/docs/hosting/full-config#rewrites

Release Note Template for Downstream PRs (will be copied)

firebasehosting: added `path` field to `google_firebase_hosting_version`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from trodge April 15, 2024 14:08
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/firebase and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Apr 15, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 32 insertions(+))
google-beta provider: Diff ( 3 files changed, 108 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • firebasehosting

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaseHostingVersion_firebasehostingVersionPathExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFirebaseHostingVersion_firebasehostingVersionPathExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Contributor

@rainshen49 rainshen49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me from the Firebase side. Thank you for your contribution!

@trodge trodge merged commit 19039f0 into GoogleCloudPlatform:main Apr 17, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants