Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill terraform_labels with state upgrader for the immutable MMv1 resources #1697

Conversation

modular-magician
Copy link
Collaborator

fixes hashicorp/terraform-provider-google#16424

Backfill terraform_labels with state upgrader for the immutable MMv1 resources

  • Beyondcorp_app_gateway
  • Certificate_manager_certificate_issuance_config
  • Datastream_private_connection
  • Ml_engine_model
  • Network_services_service_binding (beta)
  • Bigquery_job
  • Cloud_run_domain_mapping

Two immutable resources are not impacted and not state upgrader is added for them.

  • Network_connectivity_policy_based_route (added in 5.4)
  • Database_migration_servcie_private_connection (added in 5.1)

Release Note Template for Downstream PRs (will be copied)

provider: backfilled `terraform_labels` for some immutable resources, so resource recreation won't happen during provider upgrade from 4.X to 5.7

Derived from GoogleCloudPlatform/magic-modules#9438

…resources (#9438)

[upstream:61ca630b03604b8cab95d14849022aebf88971e5]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner November 13, 2023 18:55
@modular-magician modular-magician requested review from shuyama1 and removed request for a team November 13, 2023 18:55
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit fe247bf into GoogleCloudPlatform:main Nov 13, 2023
5 checks passed
@modular-magician modular-magician deleted the downstream-pr-61ca630b03604b8cab95d14849022aebf88971e5 branch November 18, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant