Backfill terraform_labels with state upgrader for the immutable MMv1 resources

[zli82016]

fixes hashicorp/terraform-provider-google#16424

Backfill terraform_labels with state upgrader for the immutable MMv1 resources

• Beyondcorp_app_gateway
• Certificate_manager_certificate_issuance_config
• Datastream_private_connection
• Ml_engine_model
• Network_services_service_binding (beta)
• Bigquery_job
• Cloud_run_domain_mapping

Two immutable resources are not impacted and not state upgrader is added for them.

• Network_connectivity_policy_based_route (added in 5.4)
• Database_migration_servcie_private_connection (added in 5.1)

Release Note Template for Downstream PRs (will be copied)

provider: backfilled `terraform_labels` for some immutable resources, so resource recreation won't happen during provider upgrade from 4.X to 5.7

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 1844 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 11 files changed, 1926 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 3224
Passed tests 2894
Skipped tests: 327
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunDomainMapping_migration1|TestAccCloudRunDomainMapping_migration|TestAccHealthcareDatasetIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudRunDomainMapping_migration1[Debug log]
TestAccCloudRunDomainMapping_migration[Debug log]
TestAccHealthcareDatasetIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccCloudRunDomainMapping_migration[Error message] [Debug log]
TestAccCloudRunDomainMapping_migration1[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 1811 insertions(+))
Terraform Beta: Diff ( 10 files changed, 1893 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3224
Passed tests 2894
Skipped tests: 328
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigqueryConnectionConnection_bigqueryConnectionAwsUpdate|TestAccDataprocJobIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigqueryConnectionConnection_bigqueryConnectionAwsUpdate[Debug log]
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1472 insertions(+))
Terraform Beta: Diff ( 8 files changed, 1554 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3225
Passed tests 2895
Skipped tests: 329
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[zli82016]

Tested the provider upgrade from 4.84 and 5.5 to the new provider for the resources

• Beyondcorp_app_gateway
• Certificate_manager_certificate_issuance_config
• Datastream_private_connection
• Ml_engine_model
• Network_services_service_binding (beta)
• Bigquery_job
• Cloud_run_domain_mapping

[rileykarson]

Sending to Cameron as well, still a bit behind

[c2thorn]

is there a GH issue this should link to?

[zli82016]

is there a GH issue this should link to?

Yes, linked the GH issue. Thanks for the review.