Make the PF provider configuration code process region selflinks in same way as the SDK provider #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame way as the SDK provider (#9063) * Add test for `TestGetRegionFromRegionSelfLink` used in SDK provider * Add plugin framework equivalent for `TestGetRegionFromRegionSelfLink` * Update PF provider config so test case passes - behaviour now equivalent to SDK [upstream:ab3cf39d9609ee5e7e60cd6277132d0236fe0066] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
iyabchen
and removed request for
a team
modular-magician
deleted the
downstream-pr-ab3cf39d9609ee5e7e60cd6277132d0236fe0066
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes hashicorp/terraform-provider-google#15714
This PR isn't user facing so there's no release note. After this inconsistency was added to the provider users would have had region self links not shortened in the provider config, but the value would be shortened by the
GetRegionfunctions used in resources. Redundancy between the two places prevented a bug being noticed.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9063