-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the PF provider configuration code process region selflinks in same way as the SDK provider #9063
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 85 insertions(+), 10 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccWorkstationsWorkstationConfig_update|TestAccWorkstationsWorkstationConfig_updateHostDetails |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 85 insertions(+), 10 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryDataTable_bigtable|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withKubeletConfig|TestAccContainerCluster_withAddons|TestAccDataprocClusterIamPolicy|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccWorkstationsWorkstationConfig_update |
Rerun these tests in REPLAYING mode to catch issues
|
…ame way as the SDK provider (GoogleCloudPlatform#9063) * Add test for `TestGetRegionFromRegionSelfLink` used in SDK provider * Add plugin framework equivalent for `TestGetRegionFromRegionSelfLink` * Update PF provider config so test case passes - behaviour now equivalent to SDK
Closes hashicorp/terraform-provider-google#15714
This PR isn't user facing so there's no release note. After this inconsistency was added to the provider users would have had region self links not shortened in the provider config, but the value would be shortened by the
GetRegion
functions used in resources. Redundancy between the two places prevented a bug being noticed.Release Note Template for Downstream PRs (will be copied)