Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage acl samples #489

Merged
merged 3 commits into from
Sep 1, 2016
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
255 changes: 255 additions & 0 deletions storage/cloud-client/acl.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,255 @@
#!/usr/bin/env python

# Copyright 2016 Google, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""This application demonstrates how to manage access control lists (acls) in
Google Cloud Storage.

For more information, see the README.md under /storage and the documentation
at https://cloud.google.com/storage/docs/encryption.
"""

import argparse

from gcloud import storage


def get_bucket_acl(bucket_name):
Copy link
Contributor

@jerjou jerjou Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd name this print_bucket_acl instead, to be explicit (and throughout)

"""Prints out a bucket's access control list."""
storage_client = storage.Client()
bucket = storage_client.bucket(bucket_name)

for entry in bucket.acl:
print('{}: {}'.format(entry['role'], entry['entity']))


def get_bucket_acl_for_user(bucket_name, user_email):
"""Prints out a bucket's access control list for a given user."""
storage_client = storage.Client()
bucket = storage_client.bucket(bucket_name)

bucket.acl.reload()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment here explaining why you have to reload would be nice (I'm having trouble figuring out whether this + line 47 = 2 network round trips, or one; and if one, whether it happens here (probably) or below..)


# You can also use `group`, `domain`, `all_authenticated` and `all` to
# get the roles for different types of entities.
roles = bucket.acl.user(user_email).get_roles()

print(roles)


def set_bucket_acl(bucket_name, user_email):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add_bucket_owner?

"""Adds a user as an owner on the given bucket."""
storage_client = storage.Client()
bucket = storage_client.bucket(bucket_name)

# You can also use `group`, `domain`, `all_authenticated` and `all` to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say .group(), etc, to make it easier to figure out that you're replacing .user() (as opposed to user_email or something)

# grant access to different types of entities. You can also use
# `grant_read` or `grant_write` to grant different roles.
bucket.acl.user(user_email).grant_owner()
bucket.acl.save()

print('Added user {} as an owner on bucket {}.'.format(
user_email, bucket_name))


def remove_bucket_acl(bucket_name, user_email):
"""Removes a user from the access control list of the given bucket."""
storage_client = storage.Client()
bucket = storage_client.bucket(bucket_name)

# You can also use `group`, `domain`, `all_authenticated` and `all` to
# remove access for different types of entities.
bucket.acl.user(user_email).revoke_read()
bucket.acl.user(user_email).revoke_write()
bucket.acl.user(user_email).revoke_owner()
bucket.acl.save()

print('Removed user {} from bucket {}.'.format(
user_email, bucket_name))


def set_bucket_default_acl(bucket_name, user_email):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add_bucket_default_owner?

"""Adds a user as an owner in the given bucket's default object access
control list."""
storage_client = storage.Client()
bucket = storage_client.bucket(bucket_name)

# You can also use `group`, `domain`, `all_authenticated` and `all` to
# grant access to different types of entities. You can also use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A newline between sentences would make it easier to scan, since the sentences are about different subjects.

# `grant_read` or `grant_write` to grant different roles.
bucket.default_object_acl.user(user_email).grant_owner()
bucket.default_object_acl.save()

print('Added user {} as an owner in the default acl on bucket {}.'.format(
user_email, bucket_name))


def remove_bucket_default_acl(bucket_name, user_email):
"""Removes a user from the access control list of the given bucket's
default object access control list."""
storage_client = storage.Client()
bucket = storage_client.bucket(bucket_name)

# You can also use `group`, `domain`, `all_authenticated` and `all` to
# remove access for different types of entities.
bucket.default_object_acl.user(user_email).revoke_read()
bucket.default_object_acl.user(user_email).revoke_write()
bucket.default_object_acl.user(user_email).revoke_owner()
bucket.default_object_acl.save()

print('Removed user {} from the default acl of bucket {}.'.format(
user_email, bucket_name))


def get_blob_acl(bucket_name, blob_name):
"""Prints out a blob's access control list."""
storage_client = storage.Client()
bucket = storage_client.bucket(bucket_name)
blob = bucket.blob(blob_name)

for entry in blob.acl:
print('{}: {}'.format(entry['role'], entry['entity']))


def get_blob_acl_for_user(bucket_name, blob_name, user_email):
"""Prints out a bucket's access control list for a given user."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'bucket' -> 'blob'

storage_client = storage.Client()
bucket = storage_client.bucket(bucket_name)
blob = bucket.blob(blob_name)

blob.acl.reload()

# You can also use `group`, `domain`, `all_authenticated` and `all` to
# get the roles for different types of entities.
roles = blob.acl.user(user_email).get_roles()

print(roles)


def set_blob_acl(bucket_name, blob_name, user_email):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_blob_acl -> add_blob_owner

or something similar, to make explicit that you're adding an owner, as opposed to setting a generic acl

"""Adds a user as an owner on the given blob."""
storage_client = storage.Client()
bucket = storage_client.bucket(bucket_name)
blob = bucket.blob(blob_name)

# You can also use `group`, `domain`, `all_authenticated` and `all` to
# grant access to different types of entities. You can also use
# `grant_read` or `grant_write` to grant different roles.
blob.acl.user(user_email).grant_owner()
blob.acl.save()

print('Added user {} as an owner on blob {} in bucket {}.'.format(
user_email, blob_name, bucket_name))


def remove_blob_acl(bucket_name, blob_name, user_email):
"""Removes a user from the access control list of the given blob in the
given bucket."""
storage_client = storage.Client()
bucket = storage_client.bucket(bucket_name)
blob = bucket.blob(blob_name)

# You can also use `group`, `domain`, `all_authenticated` and `all` to
# remove access for different types of entities.
blob.acl.user(user_email).revoke_read()
blob.acl.user(user_email).revoke_write()
blob.acl.user(user_email).revoke_owner()
blob.acl.save()

print('Removed user {} from blob {} in bucket {}.'.format(
user_email, blob_name, bucket_name))


if __name__ == '__main__':
parser = argparse.ArgumentParser(
description=__doc__,
formatter_class=argparse.RawDescriptionHelpFormatter)
subparsers = parser.add_subparsers(dest='command')

get_bucket_acl_parser = subparsers.add_parser(
'get-bucket-acl', help=get_bucket_acl.__doc__)
get_bucket_acl_parser.add_argument('bucket_name')

get_bucket_acl_for_user_parser = subparsers.add_parser(
'get-bucket-acl-for-user', help=get_bucket_acl.__doc__)
get_bucket_acl_for_user_parser.add_argument('bucket_name')
get_bucket_acl_for_user_parser.add_argument('user_email')

set_bucket_acl_parser = subparsers.add_parser(
'set-bucket-acl', help=set_bucket_acl.__doc__)
set_bucket_acl_parser.add_argument('bucket_name')
set_bucket_acl_parser.add_argument('user_email')

remove_bucket_acl_parser = subparsers.add_parser(
'remove-bucket-acl', help=remove_bucket_acl.__doc__)
remove_bucket_acl_parser.add_argument('bucket_name')
remove_bucket_acl_parser.add_argument('user_email')

set_bucket_default_acl_parser = subparsers.add_parser(
'set-bucket-default-acl', help=set_bucket_default_acl.__doc__)
set_bucket_default_acl_parser.add_argument('bucket_name')
set_bucket_default_acl_parser.add_argument('user_email')

remove_bucket_default_acl_parser = subparsers.add_parser(
'remove-bucket-default-acl', help=remove_bucket_default_acl.__doc__)
remove_bucket_default_acl_parser.add_argument('bucket_name')
remove_bucket_default_acl_parser.add_argument('user_email')

get_blob_acl_parser = subparsers.add_parser(
'get-blob-acl', help=get_blob_acl.__doc__)
get_blob_acl_parser.add_argument('bucket_name')
get_blob_acl_parser.add_argument('blob_name')

get_blob_acl_for_user_parser = subparsers.add_parser(
'get-blob-acl-for-user', help=get_blob_acl_for_user.__doc__)
get_blob_acl_for_user_parser.add_argument('bucket_name')
get_blob_acl_for_user_parser.add_argument('blob_name')
get_blob_acl_for_user_parser.add_argument('user_email')

set_blob_acl_parser = subparsers.add_parser(
'set-blob-acl', help=set_blob_acl.__doc__)
set_blob_acl_parser.add_argument('bucket_name')
set_blob_acl_parser.add_argument('blob_name')
set_blob_acl_parser.add_argument('user_email')

remove_blob_acl_parser = subparsers.add_parser(
'remove-blob-acl', help=remove_blob_acl.__doc__)
remove_blob_acl_parser.add_argument('bucket_name')
remove_blob_acl_parser.add_argument('blob_name')
remove_blob_acl_parser.add_argument('user_email')

args = parser.parse_args()

if args.command == 'get-bucket-acl':
get_bucket_acl(args.bucket_name)
elif args.command == 'get-bucket-acl-for-user':
get_bucket_acl_for_user(args.bucket_name, args.user_email)
elif args.command == 'set-bucket-acl':
set_bucket_acl(args.bucket_name, args.user_email)
elif args.command == 'remove-bucket-acl':
remove_bucket_acl(args.bucket_name, args.user_email)
elif args.command == 'set-bucket-default-acl':
set_bucket_default_acl(args.bucket_name, args.user_email)
elif args.command == 'remove-bucket-default-acl':
remove_bucket_default_acl(args.bucket_name, args.user_email)
elif args.command == 'get-blob-acl':
get_blob_acl(args.bucket_name, args.blob_name)
elif args.command == 'get-blob-acl-for-user':
get_blob_acl_for_user(
args.bucket_name, args.blob_name, args.user_email)
elif args.command == 'set-blob-acl':
set_blob_acl(args.bucket_name, args.blob_name, args.user_email)
elif args.command == 'remove-blob-acl':
remove_blob_acl(args.bucket_name, args.blob_name, args.user_email)
135 changes: 135 additions & 0 deletions storage/cloud-client/acl_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
# Copyright 2016 Google, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from gcloud import storage
import gcloud.storage.acl
import pytest

import acl

# Typically we'd use a @example.com address, but GCS requires a real Google
# account.
TEST_EMAIL = '[email protected]'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could get this from the environment, or use a service account?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be part of cloud_config, but it's not really worth the effort. Let me see if [email protected] or '[email protected]` will work.



@pytest.fixture
def test_bucket(cloud_config):
"""Yields a bucket that resets its acl after the test completes."""
bucket = storage.Client().bucket(cloud_config.storage_bucket)
acl = gcloud.storage.acl.BucketACL(bucket)
object_default_acl = gcloud.storage.acl.DefaultObjectACL(bucket)
acl.reload()
object_default_acl.reload()
yield bucket
acl.save()
object_default_acl.save()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see what you're doing here. Nice.



@pytest.fixture
def test_blob(cloud_config):
"""Yields a blob that resets its acl after the test completes."""
bucket = storage.Client().bucket(cloud_config.storage_bucket)
blob = bucket.blob('storage_acl_test_sigil')
blob.upload_from_string('Hello, is it me you\'re looking for?')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh. Might want to include a pointer back to this test, in case someone sees this object and is like, "wtf is this object"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the file is the pointer back to this test storage_acl_test_sigil.

acl = gcloud.storage.acl.ObjectACL(blob)
acl.reload()
yield blob
acl.save()


def test_get_bucket_acl(cloud_config, capsys):
acl.get_bucket_acl(cloud_config.storage_bucket)
out, _ = capsys.readouterr()
assert out


def test_get_bucket_acl_for_user(test_bucket, cloud_config, capsys):
test_bucket.acl.user(TEST_EMAIL).grant_owner()
test_bucket.acl.save()

acl.get_bucket_acl_for_user(cloud_config.storage_bucket, TEST_EMAIL)

out, _ = capsys.readouterr()
assert 'OWNER' in out


def test_set_bucket_acl(test_bucket, cloud_config):
acl.set_bucket_acl(cloud_config.storage_bucket, TEST_EMAIL)

test_bucket.acl.reload()
assert 'OWNER' in test_bucket.acl.user(TEST_EMAIL).get_roles()


def test_remove_bucket_acl(test_bucket, cloud_config):
test_bucket.acl.user(TEST_EMAIL).grant_owner()
test_bucket.acl.save()

acl.remove_bucket_acl(cloud_config.storage_bucket, TEST_EMAIL)

test_bucket.acl.reload()
assert 'OWNER' not in test_bucket.acl.user(TEST_EMAIL).get_roles()


def test_set_bucket_default_acl(test_bucket, cloud_config):
acl.set_bucket_default_acl(cloud_config.storage_bucket, TEST_EMAIL)

test_bucket.default_object_acl.reload()
roles = test_bucket.default_object_acl.user(TEST_EMAIL).get_roles()
assert 'OWNER' in roles


def test_remove_bucket_default_acl(test_bucket, cloud_config):
test_bucket.acl.user(TEST_EMAIL).grant_owner()
test_bucket.acl.save()

acl.remove_bucket_default_acl(cloud_config.storage_bucket, TEST_EMAIL)

test_bucket.default_object_acl.reload()
roles = test_bucket.default_object_acl.user(TEST_EMAIL).get_roles()
assert 'OWNER' not in roles


def test_get_blob_acl(test_blob, cloud_config, capsys):
acl.get_blob_acl(cloud_config.storage_bucket, test_blob.name)
out, _ = capsys.readouterr()
assert out


def test_get_blob_acl_for_user(test_blob, cloud_config, capsys):
test_blob.acl.user(TEST_EMAIL).grant_owner()
test_blob.acl.save()

acl.get_blob_acl_for_user(
cloud_config.storage_bucket, test_blob.name, TEST_EMAIL)

out, _ = capsys.readouterr()
assert 'OWNER' in out


def test_set_blob_acl(test_blob, cloud_config):
acl.set_blob_acl(cloud_config.storage_bucket, test_blob.name, TEST_EMAIL)

test_blob.acl.reload()
assert 'OWNER' in test_blob.acl.user(TEST_EMAIL).get_roles()


def test_remove_blob_acl(test_blob, cloud_config):
test_blob.acl.user(TEST_EMAIL).grant_owner()
test_blob.acl.save()

acl.remove_blob_acl(
cloud_config.storage_bucket, test_blob.name, TEST_EMAIL)

test_blob.acl.reload()
assert 'OWNER' not in test_blob.acl.user(TEST_EMAIL).get_roles()