Add storage acl samples #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ib44f9bb42bf0c0607e64905a26369f06ea5fb231
googlebot
added
the
cla: yes
| from gcloud import storage | ||
|
|
||
|
|
||
| def get_bucket_acl(bucket_name): |
There was a problem hiding this comment.
I'd name this print_bucket_acl instead, to be explicit (and throughout)
|
Looks good. Mainly just naming nits. |
I was trying to match the region tag names in the node.js samples, but I like your name suggestions better. |
Change-Id: I94973a839f38ef3d1ec657c3c79f666eca56728b
|
Review comments addressed. |
|
@dpebot merge when travis passes |
|
Okay! I'll merge when all statuses are green. |
dpebot
added
the
automerge
|
FYI travis is unhappy. Does dpebot notify you of such things? |
|
@jerjou: he does not, but I would like to add that feature. |
Change-Id: Ie9cf585303931f200a763d691906ad56221105fd
arbrown
pushed a commit
that referenced
this pull request
Nov 7, 2022
arbrown
pushed a commit
that referenced
this pull request
Nov 7, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 9, 2022
msampathkumar
pushed a commit
that referenced
this pull request
Nov 14, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @ryanmats