Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Authorization header support into the example app #568

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

TheSpiritXIII
Copy link
Member

@TheSpiritXIII TheSpiritXIII commented Sep 14, 2023

Example with bearer token:

go run ./examples/instrumentation/go-synthetic/ --auth-scheme=Bearer --auth-parameters=xyz
curl -H "Authorization: Bearer xyz" localhost:8080/metrics

This PR builds on top of #567.

@TheSpiritXIII TheSpiritXIII changed the title Add BasicAuth support into the example app Add Authorization header support into the example app Sep 14, 2023
@pintohutch
Copy link
Collaborator

I'm going to let @macxamin take point on the review here. I will drop myself.

@pintohutch pintohutch removed their request for review September 14, 2023 19:55
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/synthetic-auth branch from 3fde377 to cc830d0 Compare September 14, 2023 20:53
@TheSpiritXIII TheSpiritXIII marked this pull request as ready for review September 14, 2023 20:54
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/synthetic-auth branch from cc830d0 to a2ed122 Compare September 19, 2023 19:35
Copy link
Collaborator

@maxamins maxamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/synthetic-auth branch from a2ed122 to 4522705 Compare September 19, 2023 19:46
@TheSpiritXIII TheSpiritXIII merged commit b314acb into main Sep 19, 2023
7 checks passed
@TheSpiritXIII TheSpiritXIII deleted the TheSpiritXIII/synthetic-auth branch October 6, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants