Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BasicAuth support into the example app #567

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Add BasicAuth support into the example app #567

merged 1 commit into from
Sep 19, 2023

Conversation

TheSpiritXIII
Copy link
Member

Example usage:

go run ./examples/instrumentation/go-synthetic/ --basic-auth-username=admin --basic-auth-password=pw
curl localhost:8080/metrics -u "admin:pw"

@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/synthetic-basicauth branch from b2da116 to 48dfd41 Compare September 14, 2023 13:23
@pintohutch
Copy link
Collaborator

Gonna let @macxamin handle this - dropping myself.

@pintohutch pintohutch removed their request for review September 14, 2023 19:57
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/synthetic-basicauth branch from 48dfd41 to f08290c Compare September 14, 2023 20:53
@TheSpiritXIII TheSpiritXIII mentioned this pull request Sep 14, 2023
Merged
@maxamins
Copy link
Collaborator

Can you add instructions on how to use it to the README? So we can have a record on how to run with all the different auth modes?

@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/synthetic-basicauth branch from f08290c to 834008c Compare September 19, 2023 19:22
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/synthetic-basicauth branch from 834008c to 173c0ef Compare September 19, 2023 19:33
maxamins
maxamins approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@maxamins maxamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@TheSpiritXIII TheSpiritXIII merged commit a82f621 into main Sep 19, 2023
8 checks passed
@TheSpiritXIII TheSpiritXIII deleted the TheSpiritXIII/synthetic-basicauth branch September 19, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxamins maxamins maxamins approved these changes

@bwplotka bwplotka Awaiting requested review from bwplotka

Assignees

@maxamins maxamins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSpiritXIII @pintohutch @maxamins