Small fixups for resource detector code and tests #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
changed the title
aabmass
force-pushed
the
resource-fixup-1
branch
from
d5cd63f to
ed8ed26
Compare
aabmass
force-pushed
the
resource-fixup-1
branch
2 times, most recently
from
24f4638 to
7340837
Compare
- Updated the tests to not leak into os.environ - Fix code to expect numeric value for `instance/id` metadata - Mark `instance/attributes` as not-total (keys are not all required)
aabmass
force-pushed
the
resource-fixup-1
branch
from
7340837 to
f41b97a
Compare
xrmx
reviewed
Jul 26, 2024
...emetry-resourcedetector-gcp/src/opentelemetry/resourcedetector/gcp_resource_detector/_gce.py
Show resolved
Hide resolved
xrmx
approved these changes
Jul 29, 2024
|
is instance/id usually an int? I thought it was a UID on cloud run... |
Hmm that's a good point. On GCE it's numeric. I can type annotate the |
aabmass
commented
Jul 30, 2024
...y-resourcedetector-gcp/src/opentelemetry/resourcedetector/gcp_resource_detector/_metadata.py
Show resolved
Hide resolved
dashpole
approved these changes
Jul 30, 2024
...y-resourcedetector-gcp/src/opentelemetry/resourcedetector/gcp_resource_detector/_metadata.py
Show resolved
Hide resolved
|
The "ops-python-e2e-cloud-functions-gen2 (opentelemetry-ops-e2e)" CI failure is because I enabled the checked but implementation is in a draft PR still. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instance/idmetadatainstance.attributesas not-total (keys are not all required)