Implement Cloud Run and Cloud Functions faas resource detection #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
added
the
automerge: exact
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge: exact
aabmass
force-pushed
the
resource-faas-2
branch
4 times, most recently
from
2222d84 to
8f8a84f
Compare
aabmass
changed the title
|
Please ignore "ops-python-e2e-cloud-functions-gen2 (opentelemetry-ops-e2e)" failure, it is implemented in the following PRs |
xrmx
approved these changes
Jul 31, 2024
xrmx
reviewed
Jul 31, 2024
...metry-resourcedetector-gcp/src/opentelemetry/resourcedetector/gcp_resource_detector/_faas.py
Show resolved
Hide resolved
dashpole
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from JS/Go implementations. Subsequent PRs for e2e tests: