Remove usage of deprecated TraceServiceStub methods #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psx95
force-pushed
the
deprecate-trace-stub
branch
from
c36e98c to
afc4aaf
Compare
|
It looks like it is already deprecated, and this PR is removing it? |
|
Do we need to provide a resolution/workaround in #277 first? |
Yes |
psx95
changed the title
psx95
changed the title
|
As discussed internally, we will accept this tech debt in order to avoid creating work for customers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change
setTraceServiceStub&getTraceServiceStub.Fixes #198
Re #277