Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated usage for TraceServiceStub in TraceExporter #198

Open
psx95 opened this issue Feb 20, 2023 · 3 comments
Open

Remove the deprecated usage for TraceServiceStub in TraceExporter #198

psx95 opened this issue Feb 20, 2023 · 3 comments
Labels
enhancement New feature or request priority: p3

Comments

@psx95
Copy link
Contributor

psx95 commented Feb 20, 2023

There is usage of deprecated methods from TraceServiceStub in the class TraceExporter.

These need to be removed and TODOs around this code need to be addressed.


In March 2024, we found that at least one major customer has code that depends on this functionality (see #277). We decided not to remove the deprecated usage to avoid rework for them. We may re-evaluate in future depending on usage.

@psx95 psx95 added the enhancement New feature or request label Feb 20, 2023
@psx95 psx95 self-assigned this Feb 20, 2023
@dashpole
Copy link
Contributor

marking as p2

@psx95
Copy link
Contributor Author

psx95 commented Mar 13, 2024

This affects #277.
It should be answered before implementing this fix.

@punya
Copy link
Contributor

punya commented Mar 26, 2024

We have decided not to remove these deprecated methods at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: p3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants