Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use real Error in tests. #192

Merged
merged 1 commit into from
Aug 29, 2016
Merged

Use real Error in tests. #192

merged 1 commit into from
Aug 29, 2016

Conversation

jmdobry
Copy link
Member

@jmdobry jmdobry commented Aug 29, 2016

First of several "mini" PRs

ace-n
ace-n reviewed Aug 29, 2016
View reviewed changes
bigquery/test/queries.test.js
@@ -85,7 +85,7 @@ describe('bigquery:query', function () {
});

it('should handle error', function () {
var error = Error('syncQueryError');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a global variable? (Or do we have to create a new one within each test?)

@ace-n
Copy link
Contributor

ace-n commented Aug 29, 2016

Can some of these be converted to one-per-file global variables?

@jmdobry
Copy link
Member Author

jmdobry commented Aug 29, 2016

How about doing something like that in a separate "Use per-file global variables in tests" PR?

@ace-n
Copy link
Contributor

ace-n commented Aug 29, 2016

Hmm - that could work, though IMHO the two are related enough to put in the same PR (since they're changing the same things).

@jmdobry
Copy link
Member Author

jmdobry commented Aug 29, 2016 •
edited
Loading

I was thinking there are other variables (other than error vars) that could benefit from going global, hence a separate PR.

@jmdobry jmdobry merged commit dbaf7b5 into master Aug 29, 2016
@jmdobry jmdobry deleted the error branch August 29, 2016 20:55
@snyk-bot snyk-bot mentioned this pull request Jul 11, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Aug 17, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Aug 28, 2020
Open
@ninadhatkar ninadhatkar mentioned this pull request Feb 23, 2021
Open
grayside pushed a commit that referenced this pull request Oct 26, 2022
@JustinBeckwith
feat: add v2 of the tasks API (#192)
c26a94f
@grayside grayside mentioned this pull request Oct 26, 2022
Merged
grayside pushed a commit that referenced this pull request Nov 3, 2022
@JustinBeckwith @grayside
feat: add v2 of the tasks API (#192)
4837706
pattishin pushed a commit that referenced this pull request Nov 9, 2022
@release-please
chore: release 2.3.5 (#193)
7decd22 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.5](https://www.github.com/googleapis/nodejs-game-servers/compare/v2.3.4...v2.3.5) (2021-06-29)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#192](https://www.github.com/googleapis/nodejs-game-servers/issues/192)) ([4d37a74](https://www.github.com/googleapis/nodejs-game-servers/commit/4d37a7497ebe77cbfabc5e2bb0ea925e7ac138bb))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
pattishin pushed a commit that referenced this pull request Nov 9, 2022
@release-please
chore: release 2.3.5 (#193)
5c42089 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.5](https://www.github.com/googleapis/nodejs-game-servers/compare/v2.3.4...v2.3.5) (2021-06-29)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#192](https://www.github.com/googleapis/nodejs-game-servers/issues/192)) ([4d37a74](https://www.github.com/googleapis/nodejs-game-servers/commit/4d37a7497ebe77cbfabc5e2bb0ea925e7ac138bb))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
pattishin pushed a commit that referenced this pull request Nov 9, 2022
@release-please
chore: release 2.3.5 (#193)
b243b40 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.5](https://www.github.com/googleapis/nodejs-game-servers/compare/v2.3.4...v2.3.5) (2021-06-29)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#192](https://www.github.com/googleapis/nodejs-game-servers/issues/192)) ([4d37a74](https://www.github.com/googleapis/nodejs-game-servers/commit/4d37a7497ebe77cbfabc5e2bb0ea925e7ac138bb))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
NimJay pushed a commit that referenced this pull request Nov 11, 2022
@release-please @NimJay
chore: release 2.3.5 (#193)
46b3ab8 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.5](https://www.github.com/googleapis/nodejs-game-servers/compare/v2.3.4...v2.3.5) (2021-06-29)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#192](https://www.github.com/googleapis/nodejs-game-servers/issues/192)) ([4d37a74](https://www.github.com/googleapis/nodejs-game-servers/commit/4d37a7497ebe77cbfabc5e2bb0ea925e7ac138bb))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation @JustinBeckwith
chore: release 1.1.1 (#192)
6b20cee 
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
@ace-n ace-n mentioned this pull request Nov 11, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation @JustinBeckwith
chore: release 1.1.1 (#192)
9d0a9e5 
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
ace-n pushed a commit that referenced this pull request Nov 14, 2022
@yoshi-automation
chore: release 1.1.1 (#192)
df25d30 
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
ace-n pushed a commit that referenced this pull request Nov 15, 2022
@yoshi-automation
chore: release 1.1.1 (#192)
3141193 
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
ace-n pushed a commit that referenced this pull request Nov 15, 2022
@yoshi-automation
chore: release 1.1.1 (#192)
e4486de 
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
ace-n pushed a commit that referenced this pull request Nov 16, 2022
@renovate @JustinBeckwith
fix(deps): update dependency yargs to v13 (#192)
fef5b4e
@ace-n ace-n mentioned this pull request Nov 16, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@renovate
fix(deps): update dependency yargs to v13 (#192)
8c95d56
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@yoshi-automation
chore: release 1.1.1 (#192)
e146830 
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@yoshi-automation
chore: release 1.1.1 (#192)
cbde3de 
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@jmdobry
Use a real Error in tests. (#192)
b04ea46
@ace-n ace-n mentioned this pull request Nov 17, 2022
Merged
unforced pushed a commit that referenced this pull request Nov 17, 2022
@renovate-bot
fix(deps): update dependency json-schema to ^0.4.0 (#192)
6bdacad
@unforced unforced mentioned this pull request Nov 17, 2022
Merged
unforced pushed a commit that referenced this pull request Nov 17, 2022
@renovate-bot
fix(deps): update dependency json-schema to ^0.4.0 (#192)
ee667c4
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@jmdobry
Use a real Error in tests. (#192)
b33e6d7
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
@renovate @ahrarmonsur
fix(deps): update dependency yargs to v13 (#192)
d6a3312
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
@yoshi-automation @ahrarmonsur
chore: release 1.1.1 (#192)
e01b8e1 
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
@renovate-bot @ahrarmonsur
fix(deps): update dependency json-schema to ^0.4.0 (#192)
0ef5764
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@jmdobry
Use a real Error in tests. (#192)
6954a75
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@jmdobry
Use a real Error in tests. (#192)
ade195d
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@jmdobry
Use a real Error in tests. (#192)
33235ab
@kweinmeister kweinmeister mentioned this pull request Nov 18, 2022
Merged
kweinmeister pushed a commit that referenced this pull request Nov 18, 2022
@JustinBeckwith
Release v0.5.1 (#192)
c0b373d
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
@release-please
chore: release 3.2.3 (#192)
ce8506b 
🤖 I have created a release \*beep\* \*boop\* 
---
### [3.2.3](https://www.github.com/googleapis/nodejs-secret-manager/compare/v3.2.2...v3.2.3) (2020-11-25)


### Bug Fixes

* **browser:** check for fetch on window ([98aaa17](https://www.github.com/googleapis/nodejs-secret-manager/commit/98aaa17c8b9c939746c218b0da3c9d299ad640e1))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@ahrarmonsur ahrarmonsur mentioned this pull request Nov 18, 2022
Merged
jsimonweb pushed a commit to jsimonweb/nodejs-docs-samples that referenced this pull request Dec 12, 2022
@enocom
feat: add support for service account impersonation (GoogleCloudPlatf…
de15073 
…orm#192)

This is a port of GoogleCloudPlatform/cloud-sql-proxy#1460.
Shabirmean pushed a commit that referenced this pull request Feb 16, 2023
@renovate @JustinBeckwith
fix(deps): update dependency @google-cloud/pubsub to ^0.22.0 (#192)
1f8b9d3
@Shabirmean Shabirmean mentioned this pull request Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ace-n ace-n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmdobry @ace-n