Use a real Error in tests. (#192)

GoogleCloudPlatform · Aug 29, 2016 · dbaf7b5 · dbaf7b5
1 parent 3607c6b
commit dbaf7b5
Show file tree

Hide file tree

Showing 12 changed files with 62 additions and 62 deletions.
diff --git a/bigquery/test/queries.test.js b/bigquery/test/queries.test.js
@@ -85,7 +85,7 @@ describe('bigquery:query', function () {
     });
 
     it('should handle error', function () {
-      var error = Error('syncQueryError');
+      var error = new Error('error');
       var example = getSample();
       example.mocks.bigquery.query = sinon.stub().callsArgWith(1, error);
       example.program.syncQuery(query, function (err, data) {
@@ -121,7 +121,7 @@ describe('bigquery:query', function () {
     });
 
     it('should handle error', function () {
-      var error = Error('asyncQueryError');
+      var error = new Error('error');
       var example = getSample();
       example.mocks.bigquery.startQuery = sinon.stub().callsArgWith(1, error);
       example.program.asyncQuery(query, function (err, job) {
@@ -193,7 +193,7 @@ describe('bigquery:query', function () {
     });
 
     it('should handle error', function () {
-      var error = Error('asyncPollError');
+      var error = new Error('error');
       var example = getSample();
       example.mocks.job.getQueryResults = sinon.stub().callsArgWith(0, error);
       example.program.asyncPoll(example.jobId, function (err, rows) {

diff --git a/bigquery/test/tables.test.js b/bigquery/test/tables.test.js
@@ -278,7 +278,7 @@ describe('bigquery:tables', function () {
     });
 
     it('should handle export error', function () {
-      var error = new Error('exportTableToGCSError');
+      var error = new Error('error');
       var example = getSample();
       var callback = sinon.stub();
       example.mocks.table.export.yields(error);

diff --git a/logging/test/logs.test.js b/logging/test/logs.test.js
@@ -74,7 +74,7 @@ describe('logging:entries', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       sample.mocks.logging.getEntries = sinon.stub().callsArgWith(1, error);
@@ -107,7 +107,7 @@ describe('logging:entries', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       sample.mocks.log.write = sinon.stub().callsArgWith(1, error);
@@ -137,7 +137,7 @@ describe('logging:entries', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       sample.mocks.log.delete = sinon.stub().callsArgWith(0, error);

diff --git a/logging/test/sinks.test.js b/logging/test/sinks.test.js
@@ -149,7 +149,7 @@ describe('logging:sinks', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       sample.mocks.sink.create = sinon.stub().callsArgWith(1, error);
@@ -180,7 +180,7 @@ describe('logging:sinks', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       sample.mocks.sink.getMetadata = sinon.stub().callsArgWith(0, error);
@@ -211,7 +211,7 @@ describe('logging:sinks', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       sample.mocks.logging.getSinks = sinon.stub().callsArgWith(0, error);
@@ -248,7 +248,7 @@ describe('logging:sinks', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       sample.mocks.sink.setMetadata = sinon.stub().callsArgWith(1, error);
@@ -278,7 +278,7 @@ describe('logging:sinks', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       sample.mocks.sink.delete = sinon.stub().callsArgWith(0, error);

diff --git a/pubsub/test/iam.test.js b/pubsub/test/iam.test.js
@@ -72,8 +72,8 @@ describe('pubsub:iam', function () {
     });
     it('should handle error', function () {
       var sample = getSample();
-      var error = 'error';
-      sample.mocks.topic.iam.getPolicy.callsArgWith(0, new Error(error));
+      var error = new Error('error');
+      sample.mocks.topic.iam.getPolicy.callsArgWith(0, error);
       sample.program.getTopicPolicy(topicName, function (err) {
         assert(err);
         assert(err.message === 'error');
@@ -100,8 +100,8 @@ describe('pubsub:iam', function () {
     });
     it('should handle error', function () {
       var sample = getSample();
-      var error = 'error';
-      sample.mocks.subscription.iam.getPolicy.callsArgWith(0, new Error(error));
+      var error = new Error('error');
+      sample.mocks.subscription.iam.getPolicy.callsArgWith(0, error);
       sample.program.getSubscriptionPolicy(subscriptionName, function (err) {
         assert(err);
         assert(err.message === 'error');
@@ -128,8 +128,8 @@ describe('pubsub:iam', function () {
     });
     it('should handle error', function () {
       var sample = getSample();
-      var error = 'error';
-      sample.mocks.topic.iam.setPolicy.callsArgWith(1, new Error(error));
+      var error = new Error('error');
+      sample.mocks.topic.iam.setPolicy.callsArgWith(1, error);
       sample.program.setTopicPolicy(topicName, function (err) {
         assert(err);
         assert(err.message === 'error');
@@ -156,8 +156,8 @@ describe('pubsub:iam', function () {
     });
     it('should handle error', function () {
       var sample = getSample();
-      var error = 'error';
-      sample.mocks.subscription.iam.setPolicy.callsArgWith(1, new Error(error));
+      var error = new Error('error');
+      sample.mocks.subscription.iam.setPolicy.callsArgWith(1, error);
       sample.program.setSubscriptionPolicy(subscriptionName, function (err) {
         assert(err);
         assert(err.message === 'error');
@@ -184,8 +184,8 @@ describe('pubsub:iam', function () {
     });
     it('should handle error', function () {
       var sample = getSample();
-      var error = 'error';
-      sample.mocks.topic.iam.testPermissions.callsArgWith(1, new Error(error));
+      var error = new Error('error');
+      sample.mocks.topic.iam.testPermissions.callsArgWith(1, error);
       sample.program.testTopicPermissions(topicName, function (err, permissions) {
         assert(err);
         assert(err.message === 'error');
@@ -213,8 +213,8 @@ describe('pubsub:iam', function () {
     });
     it('should handle error', function () {
       var sample = getSample();
-      var error = 'error';
-      sample.mocks.subscription.iam.testPermissions.callsArgWith(1, new Error(error));
+      var error = new Error('error');
+      sample.mocks.subscription.iam.testPermissions.callsArgWith(1, error);
       sample.program.testSubscriptionPermissions(subscriptionName, function (err, permissions) {
         assert(err);
         assert(err.message === 'error');

diff --git a/pubsub/test/subscriptions.test.js b/pubsub/test/subscriptions.test.js
@@ -91,8 +91,8 @@ describe('pubsub:subscriptions', function () {
     });
     it('should handle error', function () {
       var sample = getSample();
-      var error = 'error';
-      sample.mocks.pubsub.subscribe.callsArgWith(3, new Error(error));
+      var error = new Error('error');
+      sample.mocks.pubsub.subscribe.callsArgWith(3, error);
       sample.program.createSubscription(topicName, subscriptionName, function (err) {
         assert(err);
         assert(err.message === 'error');
@@ -118,8 +118,8 @@ describe('pubsub:subscriptions', function () {
     });
     it('should handle error', function () {
       var sample = getSample();
-      var error = 'error';
-      sample.mocks.subscription.delete.callsArgWith(0, new Error(error));
+      var error = new Error('error');
+      sample.mocks.subscription.delete.callsArgWith(0, error);
       sample.program.deleteSubscription(subscriptionName, function (err) {
         assert(err);
         assert(err.message === 'error');
@@ -146,8 +146,8 @@ describe('pubsub:subscriptions', function () {
     });
     it('should handle error', function () {
       var sample = getSample();
-      var error = 'error';
-      sample.mocks.pubsub.getSubscriptions.callsArgWith(1, new Error(error));
+      var error = new Error('error');
+      sample.mocks.pubsub.getSubscriptions.callsArgWith(1, error);
       sample.program.listSubscriptions(undefined, function (err, subscriptions) {
         assert(err);
         assert(err.message === 'error');
@@ -176,8 +176,8 @@ describe('pubsub:subscriptions', function () {
     });
     it('should handle pull error', function () {
       var sample = getSample();
-      var error = 'error';
-      sample.mocks.subscription.pull.callsArgWith(1, new Error(error));
+      var error = new Error('error');
+      sample.mocks.subscription.pull.callsArgWith(1, error);
       sample.program.pullMessages(subscriptionName, function (err, messages) {
         assert(err);
         assert(err.message === 'error');
@@ -186,8 +186,8 @@ describe('pubsub:subscriptions', function () {
     });
     it('should handle ack error', function () {
       var sample = getSample();
-      var error = 'error';
-      sample.mocks.subscription.ack.callsArgWith(1, new Error(error));
+      var error = new Error('error');
+      sample.mocks.subscription.ack.callsArgWith(1, error);
       sample.program.pullMessages(subscriptionName, function (err) {
         assert(err);
         assert(err.message === 'error');

diff --git a/pubsub/test/topics.test.js b/pubsub/test/topics.test.js
@@ -67,8 +67,8 @@ describe('pubsub:topics', function () {
     });
     it('should handle error', function () {
       var sample = getSample();
-      var error = 'error';
-      sample.mocks.topic.get.callsArgWith(1, new Error(error));
+      var error = new Error('error');
+      sample.mocks.topic.get.callsArgWith(1, error);
       sample.program.createTopic(topicName, function (err) {
         assert(err);
         assert(err.message === 'error');
@@ -94,8 +94,8 @@ describe('pubsub:topics', function () {
     });
     it('should handle error', function () {
       var sample = getSample();
-      var error = 'error';
-      sample.mocks.topic.delete.callsArgWith(0, new Error(error));
+      var error = new Error('error');
+      sample.mocks.topic.delete.callsArgWith(0, error);
       sample.program.deleteTopic(topicName, function (err) {
         assert(err);
         assert(err.message === 'error');
@@ -138,8 +138,8 @@ describe('pubsub:topics', function () {
     });
     it('should handle error', function () {
       var sample = getSample();
-      var error = 'error';
-      sample.mocks.topic.publish.callsArgWith(1, new Error(error));
+      var error = new Error('error');
+      sample.mocks.topic.publish.callsArgWith(1, error);
       sample.program.publishMessage(topicName, '{"data":"hello world"}', function (err, messageIds) {
         assert(err);
         assert(err.message === 'error');
@@ -159,8 +159,8 @@ describe('pubsub:topics', function () {
     });
     it('should handle error', function () {
       var sample = getSample();
-      var error = 'error';
-      sample.mocks.pubsub.getTopics.callsArgWith(0, new Error(error));
+      var error = new Error('error');
+      sample.mocks.pubsub.getTopics.callsArgWith(0, error);
       sample.program.listTopics(function (err, topics) {
         assert(err);
         assert(err.message === 'error');

diff --git a/storage/test/acl.test.js b/storage/test/acl.test.js
@@ -140,7 +140,7 @@ describe('storage:acl', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       sample.mocks.bucket.acl.add = sinon.stub().callsArgWith(1, error);
@@ -263,7 +263,7 @@ describe('storage:acl', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       var options = {
@@ -346,7 +346,7 @@ describe('storage:acl', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       var options = {

diff --git a/storage/test/buckets.test.js b/storage/test/buckets.test.js
@@ -65,7 +65,7 @@ describe('storage:buckets', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       sample.mocks.bucket.create = sinon.stub().callsArgWith(0, error);
@@ -96,7 +96,7 @@ describe('storage:buckets', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       sample.mocks.storage.getBuckets = sinon.stub().callsArgWith(0, error);
@@ -128,7 +128,7 @@ describe('storage:buckets', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       sample.mocks.bucket.delete = sinon.stub().callsArgWith(0, error);

diff --git a/storage/test/encryption.test.js b/storage/test/encryption.test.js
@@ -90,7 +90,7 @@ describe('storage:encryption', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       var options = {
@@ -135,7 +135,7 @@ describe('storage:encryption', function () {
     });
 
     it('should handle error', function () {
-      var error = 'error';
+      var error = new Error('error');
       var sample = getSample();
       var callback = sinon.stub();
       var options = {