Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates speech-to-speech and ocr-app samples. #1532

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Updates speech-to-speech and ocr-app samples. #1532

merged 1 commit into from
Oct 30, 2019

Conversation

ricalo
Copy link
Member

@ricalo ricalo commented Oct 30, 2019

  • Updates google-cloud/translate dependency to version 5.0.0.
  • Updates declaration of clients to specify the version 2 of the API instead of
    the version 3, which is the default in the Translate library.

Note: The google-cloud/translate library made v3 the default in googleapis/nodejs-translate#355

* Updates [google-cloud/translate][1] dependency to version `5.0.0`.
* Updates declaration of clients to specify the version 2 of the API instead of
the version 3, which is the default in the Translate library.

Note: The google-cloud/translate library made v3 the default in googleapis/nodejs-translate#355

[1]: https://github.com/googleapis/nodejs-translate
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2019
@ricalo
Copy link
Member Author

ricalo commented Oct 30, 2019

This replaces #1531.

@ricalo ricalo requested a review from fhinkel October 30, 2019 11:03
@ricalo
Copy link
Member Author

ricalo commented Oct 30, 2019

It looks like containerengine/hello-world failed while pulling the Docker image.

Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for functions/ocr

@fhinkel
Copy link
Contributor

fhinkel commented Oct 30, 2019

Thank you, rerunning the one failing test. Seems unreleated.

@fhinkel fhinkel merged commit 3aa32fb into GoogleCloudPlatform:master Oct 30, 2019
@ricalo ricalo deleted the translate-5.0.0 branch October 30, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants