Update dependency @google-cloud/translate to v5 - autoclosed

[renovate-bot]

This PR contains the following updates:

Package	Type	Update	Change
@google-cloud/translate	dependencies	major	^4.0.0 -> ^5.0.0

---

Release Notes

googleapis/nodejs-translate

v5.0.1

Compare Source

v5.0.0

Compare Source

⚠ BREAKING CHANGES

• this significantly changes TypeScript types and API surface from the v2 API. Reference samples/ for help making the migration from v2 to v3.

Features

• v3 is now the default API surface (#​355) (91169b4)

Bug Fixes

• remove extra brace in snippet (#​347) (6c1e95b)

4.2.1 (2019-10-22)

Bug Fixes

• deps: bump google-gax to 1.7.5 (#​345) (2c89fd0)

---

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Renovate Bot. View repository job log here.

[fhinkel]

👋 @ricalo Could you have a look at the failing speech to speech test please.

[ricalo]

@ricalo Could you have a look at the failing speech to speech test please.

It looks like the test could not find the @google-cloud/translate dependency updated in this PR. I can take a closer look later today. Not sure if it's just a temporary issue, but I'd run the tests again in the meantime.

Edit: The ocr-app fails with the same error.

[ricalo]

I'd definitely run the tests again since the google-cloud/translate team released a fix for a bad publish of the library. Check googleapis/nodejs-translate/pull/361.

Note that google-cloud/translate 5.0.0 also introduced some breaking changes. I'm not sure if that's affecting this PR.

The kokoro:run label doesn't work for me. It looks like one of the repo owners must trigger a rebuild. @fhinkel could you help with this?

[fhinkel]

Looks to me like Kokoro was run again after you applied the label. Running it one more time just in case.

[ricalo]

To update to version ^5.0.0, the speech-to-speech sample (and I assume the ocr-app sample too) should update the line that creates a new Translate object from:

const {Translate} = require('@google-cloud/translate');

to

const {Translate} = require('@google-cloud/translate').v2;

The sample builds fine locally with this change. @ace-n, let me know if you agree and I'll get a PR ready.

[ace-n]

Thanks - SGTM if it passes tests.

…

On Tue, Oct 29, 2019 at 5:08 PM Ricardo Loo Foronda < ***@***.***> wrote: To update to version ^5.0.0, the speech-to-speech sample (and I assume the ocr-app sample too) should update the line that creates a new Translate object <https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/master/functions/speech-to-speech/functions/index.js#L38> from: const {Translate} = ***@***.***/translate'); to const {Translate} = ***@***.***/translate').v2; The sample builds fine locally with this change. @ace-n <https://github.com/ace-n>, let me know if you agree and I'll get a PR ready. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1531?email_source=notifications&email_token=AARTZRMDGKRRYSBVN3OW46TQRDGA5A5CNFSM4JGAO6LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECSPURQ#issuecomment-547682886>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARTZRI67RNTYL7S6CEEZU3QRDGA5ANCNFSM4JGAO6LA> .