-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional fixes for stateful ips in (region)_instance_group_manager #9965
Additional fixes for stateful ips in (region)_instance_group_manager #9965
Conversation
/gcbrun |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccRegionInstanceGroupManager_stateful |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just checking, is there an issue filed specifically for this? hashicorp/terraform-provider-google#10908 looks like an older issue that was already marked fixed. It isn't a requirement, but I want to make sure we close any associated bugs if they're out there.
No, there's no new issue, I was cleaning up other functionality (pull/9964) and noticed something omitted with Stateful IPs |
This fixes an issue omitted during GA promotion: #9115, where changes only in stateful_(internal|external)_ip will not trigger a Patch call in the GA provider.
fixes #10908
Also, reenables a test that should no longer flake due to #9577
#13430
If this PR is for Terraform, I acknowledge that I have:
Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.
Release Note Template for Downstream PRs (will be copied)