Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fixes for stateful ips in (region)_instance_group_manager #9965

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

askubis
Copy link
Member

@askubis askubis commented Feb 12, 2024

This fixes an issue omitted during GA promotion: #9115, where changes only in stateful_(internal|external)_ip will not trigger a Patch call in the GA provider.
fixes #10908

Also, reenables a test that should no longer flake due to #9577
#13430

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Fix issue that changes only in stateful_(internal|external)_ip will not trigger a Patch call in the GA provider for compute_(region_)instance_group_manager

@askubis askubis requested a review from a team as a code owner February 12, 2024 09:04
@askubis askubis requested review from roaks3 and removed request for a team February 12, 2024 09:04
@roaks3
Copy link
Contributor

roaks3 commented Feb 15, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 2 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 1 file changed, 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 885
Passed tests: 812
Skipped tests: 72
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccRegionInstanceGroupManager_stateful

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccRegionInstanceGroupManager_stateful[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just checking, is there an issue filed specifically for this? hashicorp/terraform-provider-google#10908 looks like an older issue that was already marked fixed. It isn't a requirement, but I want to make sure we close any associated bugs if they're out there.

@askubis
Copy link
Member Author

askubis commented Feb 16, 2024

No, there's no new issue, I was cleaning up other functionality (pull/9964) and noticed something omitted with Stateful IPs

@roaks3 roaks3 merged commit 8c99637 into GoogleCloudPlatform:main Feb 16, 2024
12 of 13 checks passed
tdbhacks pushed a commit to tdbhacks/magic-modules that referenced this pull request Feb 23, 2024
Charlesleonius pushed a commit to Charlesleonius/magic-modules that referenced this pull request Feb 29, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Mar 6, 2024
Charlesleonius pushed a commit to Charlesleonius/magic-modules that referenced this pull request Mar 11, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants