Skip to content

Commit

Permalink
additional fixes for stateful ips (GoogleCloudPlatform#9965)
Browse files Browse the repository at this point in the history
  • Loading branch information
askubis authored and BBBmau committed Mar 6, 2024
1 parent cb45ac2 commit 3c09df8
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -904,17 +904,10 @@ func resourceComputeInstanceGroupManagerUpdate(d *schema.ResourceData, meta inte
}
<% end -%>

<% unless version == "ga" -%>
if d.HasChange("stateful_internal_ip") || d.HasChange("stateful_external_ip") || d.HasChange("stateful_disk") {
updatedManager.StatefulPolicy = expandStatefulPolicy(d)
change = true
}
<% else -%>
if d.HasChange("stateful_disk") {
updatedManager.StatefulPolicy = expandStatefulPolicy(d)
change = true
}
<% end -%>

if d.HasChange("list_managed_instances_results") {
updatedManager.ListManagedInstancesResults = d.Get("list_managed_instances_results").(string)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -847,17 +847,10 @@ func resourceComputeRegionInstanceGroupManagerUpdate(d *schema.ResourceData, met
change = true
}

<% unless version == "ga" -%>
if d.HasChange("stateful_internal_ip") || d.HasChange("stateful_external_ip") || d.HasChange("stateful_disk") {
updatedManager.StatefulPolicy = expandStatefulPolicy(d)
change = true
}
<% else -%>
if d.HasChange("stateful_disk") {
updatedManager.StatefulPolicy = expandStatefulPolicy(d)
change = true
}
<% end -%>

<% unless version == "ga" -%>
if d.HasChange("all_instances_config") {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,6 @@ func TestAccRegionInstanceGroupManager_distributionPolicy(t *testing.T) {
}

func TestAccRegionInstanceGroupManager_stateful(t *testing.T) {
// TODO: Flaky test due to ordering of IPs https://github.com/hashicorp/terraform-provider-google/issues/13430
t.Skip()
t.Parallel()

template := fmt.Sprintf("tf-test-rigm-%s", acctest.RandString(t, 10))
Expand Down

0 comments on commit 3c09df8

Please sign in to comment.