-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stack_type attribute #9890
add stack_type attribute #9890
Conversation
Hello! I am a robot. It looks like you are a: @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 42 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_interconnect_attachment" "primary" {
stack_type = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM given lack of testability
@c2thorn Do you mind merging in that case? I don't have access to. |
Add
stack_type
attribute forgoogle_compute_interconnect_attachment
resource.Note: Explicit test for this attribute cannot be added in examples because this attribute cannot be added for attachments of type
PARTNER
, attachments of typeDEDICATED
requireinterconnect
to be specified, and there is no Terraform resource for creating an interconnect. Attachments of typePARTNER_PROVIDER
cannot be created without being an approved partner.Fixes: hashicorp/terraform-provider-google#17129
Release Note Template for Downstream PRs (will be copied)