Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stack_type attribute #9890

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

ehorning
Copy link
Contributor

@ehorning ehorning commented Jan 29, 2024

Add stack_type attribute for google_compute_interconnect_attachment resource.

Note: Explicit test for this attribute cannot be added in examples because this attribute cannot be added for attachments of type PARTNER, attachments of type DEDICATED require interconnect to be specified, and there is no Terraform resource for creating an interconnect. Attachments of type PARTNER_PROVIDER cannot be created without being an approved partner.

Fixes: hashicorp/terraform-provider-google#17129

Release Note Template for Downstream PRs (will be copied)

compute: added `stack_type` attribute for `google_compute_interconnect_attachment` resource.

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 42 insertions(+))
Terraform Beta: Diff ( 2 files changed, 42 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect_attachment (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect_attachment" "primary" {
  stack_type = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 868
Passed tests 804
Skipped tests: 64
Affected tests: 0

Click here to see the affected service packages
  • compute

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given lack of testability

@ehorning
Copy link
Contributor Author

LGTM given lack of testability

@c2thorn Do you mind merging in that case? I don't have access to.

@c2thorn c2thorn merged commit c918707 into GoogleCloudPlatform:main Jan 30, 2024
16 checks passed
@ehorning ehorning deleted the add-stack-type-attribute branch January 30, 2024 16:56
tdbhacks pushed a commit to tdbhacks/magic-modules that referenced this pull request Feb 6, 2024
@ehorning ehorning mentioned this pull request Mar 25, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add stack_type field to google_compute_interconnect_attachment resource
3 participants